Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb/symtab] Fix DW_TAG_member regression
Date: Sun, 9 Nov 2025 07:44:42 +0100	[thread overview]
Message-ID: <d8f3b540-f09f-4420-837c-f66cc3be6036@suse.de> (raw)
In-Reply-To: <87ecs2e4c9.fsf@tromey.com>

On 9/19/25 7:31 PM, Tom Tromey wrote:
> Tom> +  if (tag == DW_TAG_member)
> Tom> +    {
> Tom> +      /* A cooked index entry generated for a DW_TAG_member should be treated
> Tom> +	 the same as one generated for a DW_TAG_variable.  Normalize to
> Tom> +	 DW_TAG_variable, to simplify code dealing with cooked index
> Tom> +	 entries.  */
> Tom> +      tag = DW_TAG_variable;
> Tom> +    }
> 
> Forgot to mention -- we document the various gdb .debug_names
> extensions.  This rewriting qualifies as one and should be documented.
> 
> Another approach I guess would be to leave the tag alone and update the
> matching.

I've gone for the latter option.  I didn't realize this would be user 
visible, so it seems easier to just handle the DW_TAG_member.

Thanks,
- Tom

      reply	other threads:[~2025-11-09  6:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-15 15:33 Tom de Vries
2025-09-19 17:30 ` Tom Tromey
2025-11-09  6:41   ` Tom de Vries
2025-09-19 17:31 ` Tom Tromey
2025-11-09  6:44   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8f3b540-f09f-4420-837c-f66cc3be6036@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox