From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb/symtab] Fix DW_TAG_member regression
Date: Fri, 19 Sep 2025 11:31:50 -0600 [thread overview]
Message-ID: <87ecs2e4c9.fsf@tromey.com> (raw)
In-Reply-To: <20250915153334.18723-1-tdevries@suse.de> (Tom de Vries's message of "Mon, 15 Sep 2025 17:33:34 +0200")
Tom> + if (tag == DW_TAG_member)
Tom> + {
Tom> + /* A cooked index entry generated for a DW_TAG_member should be treated
Tom> + the same as one generated for a DW_TAG_variable. Normalize to
Tom> + DW_TAG_variable, to simplify code dealing with cooked index
Tom> + entries. */
Tom> + tag = DW_TAG_variable;
Tom> + }
Forgot to mention -- we document the various gdb .debug_names
extensions. This rewriting qualifies as one and should be documented.
Another approach I guess would be to leave the tag alone and update the
matching.
Tom
next prev parent reply other threads:[~2025-09-19 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-15 15:33 Tom de Vries
2025-09-19 17:30 ` Tom Tromey
2025-11-09 6:41 ` Tom de Vries
2025-09-19 17:31 ` Tom Tromey [this message]
2025-11-09 6:44 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecs2e4c9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox