From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OXRjGKuTzWg5uAoAWB0awg (envelope-from ) for ; Fri, 19 Sep 2025 13:32:27 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=I4VdZKsK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5F1111E04C; Fri, 19 Sep 2025 13:32:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0AC8C1E04C for ; Fri, 19 Sep 2025 13:32:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0AB43858D21 for ; Fri, 19 Sep 2025 17:32:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0AB43858D21 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=I4VdZKsK Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id 73BC83858D21 for ; Fri, 19 Sep 2025 17:31:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 73BC83858D21 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 73BC83858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758303113; cv=none; b=oQtMVic381IEqJSZJyTCrAvZwHXSC1UvIkbuIy2d6iZBCGgj3j/Wld47pZpgyGBIexi63xU9jLi68Zvx3smQtHk6EJvKDax6+uFQR5BDegAN4Es2KPS1y1lM5lYvnT+KGFQCDTUsQpH4Lalcray6hBapfryK84xC4927Og9CKGY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758303113; c=relaxed/simple; bh=YFKATY1h0Jf72y4iQ70hja1Rt0QfnKuHyrfs/DcOhGM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=mOvdok4eYVNFh6Gc6K+p2Q70O2YY/45M9po8zk+KJJM99d9BBsKfSk76E7K0zISP7srC7YPh/5erdXPmwffFcdV/pKdAO5dFGWcl+wEJbBy7W9hD24PYBxyAb0kZIa4ozW1WETb1v4ph1Cd1QbOxHA2xQ7sFM5CSNx1euUuhkgk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73BC83858D21 Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id zPTouV18WaPqLzexcuMO46; Fri, 19 Sep 2025 17:31:52 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zexbuZFWG0HUDzexcuMYIq; Fri, 19 Sep 2025 17:31:52 +0000 X-Authority-Analysis: v=2.4 cv=TIhFS0la c=1 sm=1 tr=0 ts=68cd9388 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=iZqkOtFUAyEJn7n2oG0A:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=K+wnshUkJNJyc2ywPYtj0eeQCK6E/6tozc4nL9YhxKo=; b=I4VdZKsKExWF/RZL8sZlcRQRZc P2Xb23viOBqmP2urd2H6AqLAL4eWd9C5ne6JNPoeG0uFiIYw9/0sffZJ/4LHJbxrPdK0TZyBd3/4b IxEBYjL0qytcCvHcraiUkZB7o; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:33554 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uzexb-00000001CzV-2G94; Fri, 19 Sep 2025 11:31:51 -0600 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] [gdb/symtab] Fix DW_TAG_member regression In-Reply-To: <20250915153334.18723-1-tdevries@suse.de> (Tom de Vries's message of "Mon, 15 Sep 2025 17:33:34 +0200") References: <20250915153334.18723-1-tdevries@suse.de> X-Attribution: Tom Date: Fri, 19 Sep 2025 11:31:50 -0600 Message-ID: <87ecs2e4c9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uzexb-00000001CzV-2G94 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:33554 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNz8lZP58no5xf6g3R/Bhw2AHjnYxFA6hUy5YgANtBjmdj70MMFdtnpIfjRhyG2XtlxggJk4w4dRs2VISwANsyQMzGt5YP50eAyDwO8QlRe5lYMIMULy FSjga04/bF1ReN3JiXwEC2BaGDcS1Q43bQrehVOevtsoaKpULSDrWi/Opn4UDHdIkIkRjlZ6RhrQbtihFOA5g+LxB9KWLz7sk5g= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom> + if (tag == DW_TAG_member) Tom> + { Tom> + /* A cooked index entry generated for a DW_TAG_member should be treated Tom> + the same as one generated for a DW_TAG_variable. Normalize to Tom> + DW_TAG_variable, to simplify code dealing with cooked index Tom> + entries. */ Tom> + tag = DW_TAG_variable; Tom> + } Forgot to mention -- we document the various gdb .debug_names extensions. This rewriting qualifies as one and should be documented. Another approach I guess would be to leave the tag alone and update the matching. Tom