From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id S6DqGXo4EGnaii4AWB0awg (envelope-from ) for ; Sun, 09 Nov 2025 01:45:14 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=J1C9njCr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pJNtYLna; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=J1C9njCr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pJNtYLna; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 58D901E0BC; Sun, 09 Nov 2025 01:45:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DB06E1E057 for ; Sun, 09 Nov 2025 01:45:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8868E385840D for ; Sun, 9 Nov 2025 06:45:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8868E385840D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=J1C9njCr; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pJNtYLna; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=J1C9njCr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=pJNtYLna Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id AE4053858D26 for ; Sun, 9 Nov 2025 06:44:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE4053858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE4053858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762670683; cv=none; b=f8U+hQt4bxJVAUuePQRBgySpD/Yexz8jWIOJ4U5ZLYfYgWb5hWXhdiIh4hclto7HqZYjTd74CyGG9l4nu6veUe0Vd2TsyMCZM8vk4ux6YfAxX9AxL9L+eBBwGLEcN4hc0Z7aip039pgRXx9iR3B4+gjP+h456cKqnQKNFTQSILY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762670683; c=relaxed/simple; bh=LV04MtOyXsIsjlYWd1ikUXtAPTxhYZWmrAUru8WwRoM=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=ANw4GimR1+2nlrsFTFz3YOC6Ix79FvUaZb2H8ay7d07vTYUkhA0k3vzCGFC89yOGjiOk5rSeeCWZ/Ld1y5anZYP7H0FdHtxhxfxElBx+kAvhVZlWCCEgCJL9ri9UBdYctH9gxaur6if6V53QO4tRmZm05+A6ssFPzKpeYDOkLL4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AE4053858D26 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9430A1F38C; Sun, 9 Nov 2025 06:44:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1762670682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDDAFjnO33jDA+bUmSC4MJ+vSO5GrPjWIvwuzkgKGlA=; b=J1C9njCrkKckLe67AtbNSL/VSA6O2YP0MXltYtC5mov1d9krhi30N8hEwniigLr+rN77x3 lPWPUX8DSGyr8xZu30o1HupzdbY6VBU7ym5bXyn6Iyc3tlASkPJ8jiRu0N+84iIZUqt4FP q3sICVvN6xJy64AwAwufAYsquAP5Bqs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1762670682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDDAFjnO33jDA+bUmSC4MJ+vSO5GrPjWIvwuzkgKGlA=; b=pJNtYLna8mJ/1SiR4t6dv3oCy+QFiJi2h/YtW0F0C6YGxrvtstSjqEPaBcIXQRaTgyIZor 8kwLXhZmdnrqiOAA== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1762670682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDDAFjnO33jDA+bUmSC4MJ+vSO5GrPjWIvwuzkgKGlA=; b=J1C9njCrkKckLe67AtbNSL/VSA6O2YP0MXltYtC5mov1d9krhi30N8hEwniigLr+rN77x3 lPWPUX8DSGyr8xZu30o1HupzdbY6VBU7ym5bXyn6Iyc3tlASkPJ8jiRu0N+84iIZUqt4FP q3sICVvN6xJy64AwAwufAYsquAP5Bqs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1762670682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tDDAFjnO33jDA+bUmSC4MJ+vSO5GrPjWIvwuzkgKGlA=; b=pJNtYLna8mJ/1SiR4t6dv3oCy+QFiJi2h/YtW0F0C6YGxrvtstSjqEPaBcIXQRaTgyIZor 8kwLXhZmdnrqiOAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7A53B13DC1; Sun, 9 Nov 2025 06:44:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 3nscHFo4EGmGPgAAD6G6ig (envelope-from ); Sun, 09 Nov 2025 06:44:42 +0000 Message-ID: Date: Sun, 9 Nov 2025 07:44:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/symtab] Fix DW_TAG_member regression To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250915153334.18723-1-tdevries@suse.de> <87ecs2e4c9.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87ecs2e4c9.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.997]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/19/25 7:31 PM, Tom Tromey wrote: > Tom> + if (tag == DW_TAG_member) > Tom> + { > Tom> + /* A cooked index entry generated for a DW_TAG_member should be treated > Tom> + the same as one generated for a DW_TAG_variable. Normalize to > Tom> + DW_TAG_variable, to simplify code dealing with cooked index > Tom> + entries. */ > Tom> + tag = DW_TAG_variable; > Tom> + } > > Forgot to mention -- we document the various gdb .debug_names > extensions. This rewriting qualifies as one and should be documented. > > Another approach I guess would be to leave the tag alone and update the > matching. I've gone for the latter option. I didn't realize this would be user visible, so it seems easier to just handle the DW_TAG_member. Thanks, - Tom