From: Pedro Alves <palves@redhat.com>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 00/31] Turn gdbserver's linux low targets into classes
Date: Wed, 1 Apr 2020 22:16:52 +0100 [thread overview]
Message-ID: <d709d157-d67e-28c5-54b9-b1990088e171@redhat.com> (raw)
In-Reply-To: <cover.1583529166.git.tankut.baris.aktemur@intel.com>
On 3/6/20 9:31 PM, Tankut Baris Aktemur wrote:
> This is a series that converts the linux low target definitions of
> gdbserver into classes that derive from 'linux_process_target'.
This is excellent, thanks much for doing this. Excellent work
splitting things up, and I like how you used the pattern
of calling the low virtual methods "low_xxx", like gdb/linux-nat.h does.
Other than the two patches I replied to, this all looks great to me.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-04-01 21:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1583529166.git.tankut.baris.aktemur@intel.com>
2020-03-19 20:13 ` [PING][PATCH " Tankut Baris Aktemur
[not found] ` <2f5f8156b5f3ceeff985dbd1af983e1212f9027e.1583529166.git.tankut.baris.aktemur@intel.com>
2020-04-01 19:15 ` [PATCH 10/31] gdbserver/linux-low: turn 'breakpoint_kind_from_{pc, current_state}' into methods Pedro Alves
2020-04-01 19:39 ` Aktemur, Tankut Baris
[not found] ` <348df510a72e111a2ce21892a50dc7ec506e2834.1583529167.git.tankut.baris.aktemur@intel.com>
2020-04-01 21:13 ` [PATCH 13/31] gdbserver/linux-low: move 'decr_pc_after_break' into linux_process_target Pedro Alves
2020-04-01 21:16 ` Pedro Alves [this message]
2020-04-02 7:33 ` [PATCH 00/31] Turn gdbserver's linux low targets into classes Aktemur, Tankut Baris
[not found] ` <57c78a1670f509b6167fe2065fa64dff37dd22c5.1583529167.git.tankut.baris.aktemur@intel.com>
2020-05-16 8:07 ` [PATCH 14/31] gdbserver/linux-low: turn 'breakpoint_at' into a method Andreas Schwab
2020-05-16 8:49 ` Aktemur, Tankut Baris
[not found] ` <9d3e8912ac039651e2e3eec2a3db2bf2bee92a4c.1583529167.git.tankut.baris.aktemur@intel.com>
2020-05-16 8:08 ` [PATCH 11/31] gdbserver/linux-low: turn 'sw_breakpoint_from_kind' " Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d709d157-d67e-28c5-54b9-b1990088e171@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox