RE: [PATCH 14/31] gdbserver/linux-low: turn 'breakpoint_at' into a method

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Saturday, May 16, 2020 10:08 AM, Andreas Schwab wrote:
> ../../gdbserver/linux-ia64-low.cc: In member function ‘virtual bool ia64_target::low_breakpoint_at(CORE_ADDR)’:
> ../../gdbserver/linux-ia64-low.cc:64:33: error: ‘gdb_assert_no_reached’ was not declared in this scope
>      "implemented by this target");
>                                  ^
> ../../gdbserver/linux-ia64-low.cc:65:1: warning: no return statement in function returning non-void [-Wreturn-type]
>  }
>  ^

Oops.  That's the risk of applying a refactoring that applies to a wide
range of targets.  I pushed the patch below.  Thanks for the notification.

-Baris


From 8bbf03947dd594262e672c1fbc3462a81c811b6f Mon Sep 17 00:00:00 2001
From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Date: Sat, 16 May 2020 10:24:24 +0200
Subject: [PATCH] gdbserver/linux-ia64-low: fix a build-breaking typo

During the gdbserver c++'ification refactoring, I apparently made a
typo that broke build in ia64 targets.

gdbserver/ChangeLog:
2020-05-16  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

	* linux-ia64-low.cc (ia64_target::sw_breakpoint_from_kind):
	Fix incorrect 'gdb_assert_no_reached' to 'gdb_assert_not_reached'.
	(ia64_target::low_breakpoint_at): Ditto.
---
 gdbserver/ChangeLog         | 6 ++++++
 gdbserver/linux-ia64-low.cc | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog
index d2b2444d09b..3a27705f8df 100644
--- a/gdbserver/ChangeLog
+++ b/gdbserver/ChangeLog
@@ -1,3 +1,9 @@
+2020-05-16  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
+
+	* linux-ia64-low.cc (ia64_target::sw_breakpoint_from_kind):
+	Fix incorrect 'gdb_assert_no_reached' to 'gdb_assert_not_reached'.
+	(ia64_target::low_breakpoint_at): Ditto.
+
 2020-05-15  Hannes Domani  <ssbssa@yahoo.de>
 
 	* win32-i386-low.cc (i386_supports_z_point_type): Handle
diff --git a/gdbserver/linux-ia64-low.cc b/gdbserver/linux-ia64-low.cc
index 83a180871dc..ee255418b0f 100644
--- a/gdbserver/linux-ia64-low.cc
+++ b/gdbserver/linux-ia64-low.cc
@@ -53,15 +53,15 @@ static ia64_target the_ia64_target;
 const gdb_byte *
 ia64_target::sw_breakpoint_from_kind (int kind, int *size)
 {
-  gdb_assert_no_reached ("target op sw_breakpoint_from_kind is not "
-			 "implemented by this target");
+  gdb_assert_not_reached ("target op sw_breakpoint_from_kind is not "
+			  "implemented by this target");
 }
 
 bool
 ia64_target::low_breakpoint_at (CORE_ADDR pc)
 {
-  gdb_assert_no_reached ("linux target op low_breakpoint_at is not "
-			 "implemented by this target");
+  gdb_assert_not_reached ("linux target op low_breakpoint_at is not "
+			  "implemented by this target");
 }
 
 /* Defined in auto-generated file reg-ia64.c.  */
-- 
2.17.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928