RE: [PATCH 10/31] gdbserver/linux-low: turn 'breakpoint_kind_from_{pc, current_state}' into methods

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Wednesday, April 1, 2020 9:16 PM, Pedro Alves wrote:
> On 3/6/20 9:31 PM, Tankut Baris Aktemur wrote:
> > @@ -257,7 +259,7 @@ riscv_breakpoint_kind_from_pc (CORE_ADDR *pcptr)
> >      }
> >    buf;
> >
> > -  if (target_read_memory (*pcptr, buf.bytes, sizeof (buf.insn)) == 0
> > +  if (read_memory (*pcptr, buf.bytes, sizeof (buf.insn)) == 0
> 
> Is this really correct?  It seems like an unrelated change.
> target_read_memory masks off breakpoint instructions, while read_memory
> doesn't, I believe.

You're right.  I was under the impression that target_read_memory was a macro
for the_target->read_memory.  It's not.  I'll check the entire series for
other occurrences of this and also target_write_memory.

Thanks.
-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928