Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFAv2] Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno.
Date: Sun, 05 Jun 2022 21:44:27 +0200	[thread overview]
Message-ID: <d6d57f1b1c90910834c745802a2b75b3a7a457f8.camel@skynet.be> (raw)
In-Reply-To: <83r1429aj4.fsf@gnu.org>

On Sun, 2022-06-05 at 22:26 +0300, Eli Zaretskii wrote:
> > From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
> > Cc: gdb-patches@sourceware.org
> > Date: Sun, 05 Jun 2022 21:09:36 +0200
> > 
> > > > +For a @samp{breakpoint-hit} stopped reason, when the breakpoint
> > > > +encountered has multiple locations, the field @samp{bkptno} is
> > > > +followed by the field @samp{locno}.
> > > 
> > > This is a backward-incompatible change, no?  Does it require bumping
> > > the version of the MI protocol?
> > The documentation indicates that adding a new field in the mi output
> > can be done without changing the MI version.
> > I have indicated the below in the commit log:
> >    Note that according to the GDB user manual node 'GDB/MI Development and Front
> >    Ends', it is ok to add new fields without changing the MI version.
> 
> Does "M-x gdb" in Emacs still work correctly after this change,
> including the display in the breakpoints buffer?
I do not see behavior changes between GDB master and GDB with this patch.
But the display of multiple code locations in the breakpoint buffer
seems to not work properly, for both the non modified master
and the gdb with this patch.

To test, I have started
  emacs -Q  # emacs 27.1
  M-x gdb
  /absolute/path/to/gdb --nh -i=mi ~/gdb/littleprogs/zeoes
  b some_func # this adds a breakpoint with 2 code locations
  M-x gdb-many-windows

And the breakpoint window shows:
Num Type       Disp Enb Addr       Hits What
1   breakpoint keep y   <MULTIPLE> 1    in unknown

Note that I have the same behavior with GNU gdb (Debian 10.1-1.7) 10.1.90.20210103-git

When I create a breakpoint with one code location, this breakpoint is properly shown:
      Disp Enb Addr               Hits What
1   breakpoint keep y   <MULTIPLE>         1    in unknown
2   breakpoint keep y   0x00005555555551c6 0    in main of zeoes.c:24

So, I am not too sure what emacs gdb mode is supposed to do with such multiple
code locations breakpoints.

Philippe


 


  reply	other threads:[~2022-06-05 19:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-05 16:57 Philippe Waroquiers via Gdb-patches
2022-06-05 17:10 ` Eli Zaretskii via Gdb-patches
2022-06-05 19:09   ` Philippe Waroquiers via Gdb-patches
2022-06-05 19:26     ` Eli Zaretskii via Gdb-patches
2022-06-05 19:44       ` Philippe Waroquiers via Gdb-patches [this message]
2022-06-06 12:44         ` Eli Zaretskii via Gdb-patches
2022-06-07 13:05         ` Eli Zaretskii via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6d57f1b1c90910834c745802a2b75b3a7a457f8.camel@skynet.be \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox