From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id r7VWO7IHnWJEfwoAWB0awg (envelope-from ) for ; Sun, 05 Jun 2022 15:44:50 -0400 Received: by simark.ca (Postfix, from userid 112) id E37CE1E221; Sun, 5 Jun 2022 15:44:50 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=l9GyxDcx; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 569481E01D for ; Sun, 5 Jun 2022 15:44:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7FD5E382F095 for ; Sun, 5 Jun 2022 19:44:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FD5E382F095 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1654458289; bh=9tMhFQCy9VZX3/9OLYuJCWdqpSLo2HHY1onAE0QCdb8=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=l9GyxDcxlNLIr9jzmgGlFNiDVrEQgTldD5f/JuOAigRgMLP0cvr9sztfHidYD5hiB 0zd29ICGqjY3GTXCWZYyT4++u29t+6n1rjkJ52Zqsu7OfDGw7M0sVFyQ27xJUbPZoy BTMW4rbCt7pIopuc947aEv8aYCtcgt6Xck7Ml/M4= Received: from mailsec211.isp.belgacom.be (mailsec211.isp.belgacom.be [195.238.22.107]) by sourceware.org (Postfix) with ESMTPS id 99739382FE48 for ; Sun, 5 Jun 2022 19:44:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99739382FE48 X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2AZAQD+Bp1i/yFRiNkNTYEJCYFGhHqETpENA5xmgXwLA?= =?us-ascii?q?QEBAQEBAQEBCUIEAQGFAgKFRyY2Bw4BAgQBAQEBAwIDAQEBAQEBAwEBBgEBA?= =?us-ascii?q?QEBAQYEAYEbhS+CeykBg2MBAQEBAyMPAUYQCxQBAwICJgICVwYTsTp6gTGBA?= =?us-ascii?q?YRugyuBZYERLIc+hyQ3gVVEhD8+iBqCZQSXCR07AxwtNBKBIXEBCAYGBwoFM?= =?us-ascii?q?gYCDBgUBAITElMdAhIFBwocDhQcJBkMDwMSAxEBBwILEggVLAgDAgMIAwIDI?= =?us-ascii?q?wsCAxcJBwoDHQgKHBIQFAIEEx4LCAMZHywJAgQOA0MICwoDEQQDExgLFggQB?= =?us-ascii?q?AYDCS8NKAsDFA8BBgMGAgUFAQMgAxQDBScHAyEHCyYNDQQcBx0DAwUmAwICG?= =?us-ascii?q?wcCAgMCBhcGAgJxCiYNCAQIBBwdJRAFAgcxBQQvAh4EBQYRCQIWAgYEBQIEB?= =?us-ascii?q?BYCAhIIAggnGwcWGR0ZAQVdBgsJIRwpCwYFBhYDI3MFCj4PKTU2PwYiAR2ZB?= =?us-ascii?q?nOBQ4EIRS0CwEE0B4NRgT0GDJ5BMahblmiiAIUzgWgCggxtgztRKI5XjhtzO?= =?us-ascii?q?wIGAQoBAQMJkBQBAQ?= IronPort-PHdr: A9a23:+JzkMhaxWDvS9pILku7Ikxj/LTG/0IqcDmcuAnoPtbtCf+yZ8oj4O wSHvLMx1gSPBN2DoKsf26L/iOPJYSQ4+5GPsXQPItRndiQuroEopTEmG9OPEkbhLfTnPGQQF cVGU0J5rTngaRAGUMnxaEfPrXKs8DUcBgvwNRZvJuTyB4Xek9m72/q99pHNbQhEniexba9uI Bm5sAncuMobipZ+J6gszRfEvmFGcPlMy2NyIlKTkRf85sOu85Nm7i9dpfEv+dNeXKvjZ6g3Q qBWAzogM2Au+c3krgLDQheV5nsdSWoZjBxFCBXY4R7gX5fxtiz6tvdh2CSfIMb7Q6w4VSik4 qx2UxLjljsJOCAl/2HWksxwjbxUoBS9pxxk3oXYZJiZOOdicq/BeN8XQ3dKUMRMWCxbGo6yb JYBAeofM+tGoYfypVUOogewCgajC+3i0SNIi3zs0KEmz+gsCwPL0Qo9FNwOqnTUq9D1Ob8IX +C1zanIyTTDb+tO2Tjj9YPHcgouoeuLXbJpbMrRyFcgFxnejl6NroHlJzOV1uUJs2ia9+pgT fygh3Qpqg5ruDivwd4sipTIho0L0FDE7j50wJ02Jdy4Tk50f8KkHIFLuC6ELoZ7RN4pTG50t igg0LIGpYK7czYQyJQh3xPSb+CLfYiU7x/iVeufLil0iX1ldr+7iBu/80qtx+78WMWpzFtGs ytIn8fMu30JyxHf99WKRPRz8Eu81zuDyQTe5+dZKk43jarWM4AtzqMym5YJrEjOEC77lF/1g aOLbEkp9Oal5uL6abv8vJCcLZV7igTmP6QrncywHPo3PxAVX2ie5eS8zLrj/VDlQLlSjv05j K3ZsJfCKMsfu6K0BxFZ3pw+5xu+DDqqyskUkWMaIF9Bfh2Ll4npO1fQL/DkFfqznUmgnTVxy /zbMLDsA4/BI3venLv7c7tw5VZQyA8pwtBe45JUBKsBIPX2WkLprNzYDh45Mwi1w+b/ENVyy JkSWGyVDa+DN6PSqEKI5uMxLOmWf48Yoy39K/sl5v7ok3A5hUURcrK30pcPbnC3BexpI1+Fb nr0ntcBDWAKsxIgQODykl2NTSZTZ2quX6I7/jw0FoamDYbCR422j7yB2jq7EodRZmBcBVCAC W3oeJmcW/cQdCKSJddskjMZWre6UoMhzQuhtBPmxLpnMOXU4TYVtYnk1Nho/e3ciQ899DJuA MSHzW6BVWZ0nnkHR2x+4KcqjEh8gmWKy6VkmP9ZFJQH6vdIQC81M4OayPZ1XYPcQAXEK++JS VKnWs2rSQ44VNUo3t4DeV01T82ijxTCxzKnRaAcjbuSGZ056Ln0xHvgIcthjXzLgvpyx2I6S 9dCYDX1zpV08BLeUsuQyx3xqg== IronPort-Data: A9a23:bXc1Vqn5jp6j9VAnPpes/5/o5gw9JERdPkR7XQ2eYbSJt1+Wr1Gzt xJLWmvTOarYM2Cmfoh+YYi+8E8H7J7Rx4BjTVE/ryxjQltH+JHPbTi7wuccHM8zwunrFh8PA xA2M4GYRCwMZiaA4E/ra9ANlFEkvU2ybuOU5NXsZ2YgHGeIdA970Ug5w7Bh39Yy6TSEK1rlV e3a8pW31GCNhmYc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pDTU2FFEYUd6EPdgKMq 0kv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOjzAazhHe3JrXO9IZORZWrj6DvOt8w YhAmp2xUA0xb6bDzbF1vxlwS0mSPIV1oe6dZyHh4YrKiRSXRhMAwd00VR5wZNZGvLYuRzoVn RAbAGllghSrn+K3xLOjUuQqmc05K9D2PY4FoVl7ziDfAOpgS52rr6Div4AAh2xh2pwm8fD2W s0pVgtdQg/7OV5KM09LKqgjpv6zryyqG9FfgBfPzUYt2EDeyA1j+LfrLZzSYNPibcpZlAOAr 37N/2niKgodKcaUxCWM6H/qgfXA9R4XQ6pJT/vor7sz2wPWnDVMThQaTl/+rei/zE+lQ5RVJ kgb8yEpqO44+SRHU+XAYvFxm1bc1jZ0ZjaaO7RSBN2lokYf3+pV6qXogNKMhBzKefLanQAX6 2I= IronPort-HdrOrdr: A9a23:yNM+U6wkN5OGxUxsWX0EKrPwJ71zdoMgy1knxilNoNJuHfBw8P re+MjztCWE6wr5N0tPpTntAsS9qDbnlKKdgrNhWItKPjOMhILAFugL0WKh+V3d8kbFnNK1u5 0NT0EzMqyTMWRH X-IronPort-Anti-Spam-Filtered: true Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO [192.168.1.19]) ([217.136.81.33]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2022 21:44:28 +0200 Message-ID: Subject: Re: [RFAv2] Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno. To: Eli Zaretskii Date: Sun, 05 Jun 2022 21:44:27 +0200 In-Reply-To: <83r1429aj4.fsf@gnu.org> References: <20220605165759.2433530-1-philippe.waroquiers@skynet.be> <83tu8z8297.fsf@gnu.org> <980bf860a6a9375968c68d1f31009ede20608226.camel@skynet.be> <83r1429aj4.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Philippe Waroquiers via Gdb-patches Reply-To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Sun, 2022-06-05 at 22:26 +0300, Eli Zaretskii wrote: > > From: Philippe Waroquiers > > Cc: gdb-patches@sourceware.org > > Date: Sun, 05 Jun 2022 21:09:36 +0200 > > > > > > +For a @samp{breakpoint-hit} stopped reason, when the breakpoint > > > > +encountered has multiple locations, the field @samp{bkptno} is > > > > +followed by the field @samp{locno}. > > > > > > This is a backward-incompatible change, no? Does it require bumping > > > the version of the MI protocol? > > The documentation indicates that adding a new field in the mi output > > can be done without changing the MI version. > > I have indicated the below in the commit log: > >    Note that according to the GDB user manual node 'GDB/MI Development and Front > >    Ends', it is ok to add new fields without changing the MI version. > > Does "M-x gdb" in Emacs still work correctly after this change, > including the display in the breakpoints buffer? I do not see behavior changes between GDB master and GDB with this patch. But the display of multiple code locations in the breakpoint buffer seems to not work properly, for both the non modified master and the gdb with this patch. To test, I have started emacs -Q # emacs 27.1 M-x gdb /absolute/path/to/gdb --nh -i=mi ~/gdb/littleprogs/zeoes  b some_func # this adds a breakpoint with 2 code locations M-x gdb-many-windows And the breakpoint window shows: Num Type Disp Enb Addr Hits What 1 breakpoint keep y 1 in unknown Note that I have the same behavior with GNU gdb (Debian 10.1-1.7) 10.1.90.20210103-git When I create a breakpoint with one code location, this breakpoint is properly shown: Disp Enb Addr Hits What 1 breakpoint keep y 1 in unknown 2 breakpoint keep y 0x00005555555551c6 0 in main of zeoes.c:24 So, I am not too sure what emacs gdb mode is supposed to do with such multiple code locations breakpoints. Philippe