Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFAv2] Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno.
Date: Sun, 05 Jun 2022 21:09:36 +0200	[thread overview]
Message-ID: <980bf860a6a9375968c68d1f31009ede20608226.camel@skynet.be> (raw)
In-Reply-To: <83tu8z8297.fsf@gnu.org>

Thanks for the (as usual) quick review.
I will send soon an RFAv3 where I have fixed all the below comments.
I also checked the occurrences of 'location' and used (code location' instead.

Some feedback for specific points:

On Sun, 2022-06-05 at 20:10 +0300, Eli Zaretskii wrote:
> 
> So how does $bkptno differ from $bpnum?
I have added the following in the manual after the first small example
showing $bkptno:

Note that @samp{$bkptno} and @samp{$bpnum} are not equivalent:
@samp{$bkptno} is set to the breakpoint number @b{last hit}, while
@samp{$bpnum} is set to the breakpoint number @b{last set}.

> > +For a @samp{breakpoint-hit} stopped reason, when the breakpoint
> > +encountered has multiple locations, the field @samp{bkptno} is
> > +followed by the field @samp{locno}.
> 
> This is a backward-incompatible change, no?  Does it require bumping
> the version of the MI protocol?
The documentation indicates that adding a new field in the mi output
can be done without changing the MI version.
I have indicated the below in the commit log:
   Note that according to the GDB user manual node 'GDB/MI Development and Front
   Ends', it is ok to add new fields without changing the MI version.

Thanks
Philippe



  reply	other threads:[~2022-06-05 19:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-05 16:57 Philippe Waroquiers via Gdb-patches
2022-06-05 17:10 ` Eli Zaretskii via Gdb-patches
2022-06-05 19:09   ` Philippe Waroquiers via Gdb-patches [this message]
2022-06-05 19:26     ` Eli Zaretskii via Gdb-patches
2022-06-05 19:44       ` Philippe Waroquiers via Gdb-patches
2022-06-06 12:44         ` Eli Zaretskii via Gdb-patches
2022-06-07 13:05         ` Eli Zaretskii via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=980bf860a6a9375968c68d1f31009ede20608226.camel@skynet.be \
    --to=gdb-patches@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=philippe.waroquiers@skynet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox