From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id siCED4n/nGJJfgoAWB0awg (envelope-from ) for ; Sun, 05 Jun 2022 15:10:01 -0400 Received: by simark.ca (Postfix, from userid 112) id 2D9861E221; Sun, 5 Jun 2022 15:10:01 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=oGU5TfPV; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B05DC1E01D for ; Sun, 5 Jun 2022 15:10:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C691C3856DD3 for ; Sun, 5 Jun 2022 19:09:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C691C3856DD3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1654456199; bh=TFjNDHrWcdT5pOFKbRGHgtchAPJfgHRKoyAruZFVnqg=; h=Subject:To:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oGU5TfPVYCA6Kf7QHrwHQ3zJO8bEIx8p6x8N+mAjjdjFmxj9w2CjTDqEquvyM+BQv QdnbJxnyD/zU3kuy4iwTGTlaGPtHkjyNdcFxiSsidrukfxdt8SWGSnCamoc/ICSLsE iGVcb6LBTSZY6QnHMCRm3LumAh6ztH+F7urS25lg= Received: from mailsec103.isp.belgacom.be (mailsec103.isp.belgacom.be [195.238.20.99]) by sourceware.org (Postfix) with ESMTPS id 49A173857829 for ; Sun, 5 Jun 2022 19:09:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49A173857829 X-ExtLoop: 1 X-IPAS-Result: =?us-ascii?q?A2AuAQAf/pxi/yFRiNkNTYEJCYFGiUiRDQOeYgsBAQEBA?= =?us-ascii?q?QEBAQEJQgQBAYUCAoVHJjcGDgECBAEBAQEDAgMBAQEBAQEDAQEGAQEBAQEBB?= =?us-ascii?q?gQBgRuFL4J7KQGDZAEBAQMjVhALGAICJgICVwaxTXqBMYEBhG6DK4FlgREsh?= =?us-ascii?q?z6HJDeBVUSEPz6IGoJlBJcJHTsDHC00EoEhcQEIBgYHCgUyBgIMGBQEAhMSU?= =?us-ascii?q?x0CEgUHChwOFBwkGQwPAxIDEQEHAgsSCBUsCAMCAwgDAgMjCwIDFwkHCgMdC?= =?us-ascii?q?AocEhAUAgQTHgsIAxkfLAkCBA4DQwgLCgMRBAMTGAsWCBAEBgMJLw0oCwMUD?= =?us-ascii?q?wEGAwYCBQUBAyADFAMFJwcDIQcLJg0NBBwHHQMDBSYDAgIbBwICAwIGFwYCA?= =?us-ascii?q?nEKJg0IBAgEHB0lEAUCBzEFBC8CHgQFBhEJAhYCBgQFAgQEFgICEggCCCcbB?= =?us-ascii?q?xYZHRkBBV0GCwkhHCkLBgUGFgMjcwUKPg8pNTY/BiIBHZkGc4FDCn4QHxaiD?= =?us-ascii?q?55hNAeDUYE9BgyeQTGVZ5J0lminM4F3gX9tgzxQKI5XjhuBLgIGCwEBAwmQF?= =?us-ascii?q?AEB?= IronPort-PHdr: A9a23:Of8WEBLpvlz0YNbWIdmcuPdmWUAX0o4c3iYr45Yqw4hDbr6kt8y7e hCFvrM01AeCBN6Do9t/yMPu+5j6XmIB5ZvT+FsjS7drEyE/tMMNggY7C9SEA0CoZNTjbig9A dgQHAQ9pyLzPkdaAtvxaEPPqXOu8zESBg//NQ1oLejpB4Lelcu62/689pHJfglEmCaxbbxvI Bi4sQnaq9Ubj5ZlJqst0BXCv2FGe/5RxWNmJFKTmwjz68Kt95N98Cpepuws+ddYXar1Y6o3Q 7pYDC87M28u/83kqQPDTQqU6XQCVGgdjwdFDBLE7BH+WZfxrzf6u+9g0ySUIcH6UbY5Uim54 qx1VBHnljsINz8h8GHWlMNwir5boAm8rBB72oLYfZ2ZOOZ7cq7bYNgUR3dOXtxJWiJCH42yb 5UBAvQPM+laoYnyu1UBohSxCwS3GOPiyCVFimPq0aAg0eksFxzN0gw6H9IJtXTZtM/7NKcTU eCxzanI1S3DYO1L0jj98ofIaBchoeiRXbJxb8XR01IvHB7Cg1WIqYzlPjeV1uUVs2iD8eVsT +yuhHQ9qwF2uziv28YshZfThoIO0V3E7iZ5wYYzJdKmVE53e8WrH4VJuiycKoB5Td8sTXtyt yYm1r0Jp4S7fC4SxZkk2hLSaviKfoeW7h7+SuucLit0iGxrdr6hiRu/7Eiux+nzWMS71FtHr ypLnsTQun0JyRHe68qKRPtz8Eq/xDuC0R3Y5OJcIU0si6bXNpwszqQtmpcdsEnPBCz7lFjsg KKYeEgp/PWj5f79bbX8vJCcMpd5igT5MqszhMOyGf84Mg0SX2iD/uS8yaHj8VX5QLpUiv02l bHUv5THKckfuKK1GRJZ34cg5hqlEjuqyskUkH0BI15deRKHiZbmO03WLfzmEPuygU6gnCply v3HJLHsAYjBImLNnbrvZbp97lRTyAs3zdBR/ZJUDbQBLerrWk/xtdzYCh45MxSsw+n5Etl82 JkRWXiIAq+ALaPSsEGH5vg0I+SXf48Vuzb8K/476P7yl3M2gkEScbGv3ZQMcH+4BOhpI12FY XrwhdcMCXkGshIkTOP2kF2CTSJTZ3GqUq0i4jE7CYOnAJzMRoCrnbyNxiC7HodZZmxeEFCDD W/od5mYW/cLcC+SLdJunScdWbi5UYAhyQ2htA/kxLp8NefU4SoYtY/51Ndp+eLSmws99SZqA MiH1GGNVW50zSs0QGob2KE3k0Vnx0uY0ql5y6hVEd1Bz/xPT0E9L5GKnMJgDNWnYgLAetaRU Fvufdy8BigsT98r2Jdae0Z8H9S6lh2FwCOwBKYIlrGRH7Qv8bPa0mS3LcsrmCWO77Uok1RzG pgHDmahnKMqslGLX+b0 IronPort-Data: A9a23:6JQ/LqBWLtbRYRVW/5bhw5YqxClBgxIJ4kV8jS/XYbTApDonhT0Cn DMaDWiBPP2MM2r1Ld9wYIyz8UtVv8DVn4UwOVdlrnsFo1CmCSbm6XV1Cm+qYkt+++WaFBoPA /02M4WGdIZtJpPljk/F3oLJ9BGQ7onVAOulYAL4EnopH1U8Fn980UsLd9MR2+aEv/DoW2thh vuv+6UzCHf9s9KjGjtJg04rgEoHUMXa4Fv0jHRnDRx4lAO2e00uMX4qDfrZw00U7WVjNrXSq +7rlNlV945ClvsnIovNfr3TKiXmTlNOVOSDoiI+ZkSsvvRNjh5si4oXM8YxUk1esxLZu49sl +pNiJPlHG/FPoWU8AgceyoBQns4ZPMWvuaBeCmK2SCR5xefLD21mKsoXBhwZtZwFuVfWAmi8 dQAKDEJbwibiqSpyai8U/Rti944BNLoLYUSpjdqwFk1CN5/Gs2THvuUu4MwMDEYouRXHKv7R eogbiNgTw2bWwZ1MXQFF8dr9AuvrjylG9FCk3qYoasly2fV0Up2yreFGNXZcJmSTNlenkuDj nnB4n7yDw4TLtHZziCKmk9AnceUxmWrAcdLT+P9rKc1xlSf3WhWBAwQE1qgub+zh0qxUtlYL goe90LCsJQPyaBidfGlNzXQnZJOlkd0twZ4ewHx1O1BJmc4LepU6qjogwOtsOAbifI= IronPort-HdrOrdr: A9a23:ekW8M6gJYZe6QHfZ8xqKaz6sCXBQXrkji2hC6mlwRA09TyVCra CTdZsguCMc5Ax7ZJhCo7G90cC7KBvhHPVOjbX5U43JYOCfggSVxfpZg7ff/w== X-IronPort-Anti-Spam-Filtered: true X-ProximusIPWarmup: true Received: from 33.81-136-217.adsl-dyn.isp.belgacom.be (HELO [192.168.1.19]) ([217.136.81.33]) by relay.proximus.be with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2022 21:09:36 +0200 Message-ID: <980bf860a6a9375968c68d1f31009ede20608226.camel@skynet.be> Subject: Re: [RFAv2] Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno. To: Eli Zaretskii Date: Sun, 05 Jun 2022 21:09:36 +0200 In-Reply-To: <83tu8z8297.fsf@gnu.org> References: <20220605165759.2433530-1-philippe.waroquiers@skynet.be> <83tu8z8297.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Philippe Waroquiers via Gdb-patches Reply-To: Philippe Waroquiers Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Thanks for the (as usual) quick review. I will send soon an RFAv3 where I have fixed all the below comments. I also checked the occurrences of 'location' and used (code location' instead. Some feedback for specific points: On Sun, 2022-06-05 at 20:10 +0300, Eli Zaretskii wrote: > > So how does $bkptno differ from $bpnum? I have added the following in the manual after the first small example showing $bkptno: Note that @samp{$bkptno} and @samp{$bpnum} are not equivalent: @samp{$bkptno} is set to the breakpoint number @b{last hit}, while @samp{$bpnum} is set to the breakpoint number @b{last set}. > > +For a @samp{breakpoint-hit} stopped reason, when the breakpoint > > +encountered has multiple locations, the field @samp{bkptno} is > > +followed by the field @samp{locno}. > > This is a backward-incompatible change, no? Does it require bumping > the version of the MI protocol? The documentation indicates that adding a new field in the mi output can be done without changing the MI version. I have indicated the below in the commit log: Note that according to the GDB user manual node 'GDB/MI Development and Front Ends', it is ok to add new fields without changing the MI version. Thanks Philippe