Re: [PATCH] [gdb/testsuite] Fix gdb.tui/resize-3.exp on ppc64-linux

[Tom de Vries <tdevries@suse.de>]

On 10/17/25 4:14 PM, Tom Tromey wrote:
> Tom> -	"$hex\\s+<foo"
> Tom> +	[string cat $hex {\s+} "<" ([string_to_regexp .])? "foo"]
> 
> Personally I find this a lot less readable than just writing out the
> regular expression.

How about:
...
set re_dot [string_to_regexp "."]
set re [string cat $hex {\s+} "<" "($re_dot)?" "foo"]
...

Or:
...
set re [string cat $hex {\s+} "<" {(\.)?} "foo"]
...

I find this style much less readable:
...
set re "$hex\\s+<(\\.)?foo"
...

That is, I don't understand why you would join logically separate parts 
of the regexp together and force readers of the regexp to go through the 
process of separating them out again.

It's also error prone, especially where the dot is concerned:
- if you forget the second backslash on the s, you get a mismatch and
   it's easily spotted.
- if you forget the second backslash on the dot, you still get a match,
   but it'll match any character, say the a in "0x00c0ffee <afoo>".
I've seen many examples of this mistake in the testsuite sources.

Thanks,
- Tom