From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id F0SUBI9O82jqhT0AWB0awg (envelope-from ) for ; Sat, 18 Oct 2025 04:23:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BlXlE69G; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wgbJwRl4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uiUbw15Q; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LpAuNNG1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F3F0E1E0BC; Sat, 18 Oct 2025 04:23:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 86A7E1E04C for ; Sat, 18 Oct 2025 04:23:41 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 73F7B3857B94 for ; Sat, 18 Oct 2025 08:23:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73F7B3857B94 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=BlXlE69G; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=wgbJwRl4; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uiUbw15Q; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LpAuNNG1 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 4726F3858D2A for ; Sat, 18 Oct 2025 08:22:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4726F3858D2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4726F3858D2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760775720; cv=none; b=XrrCAN8mEDCu82I57keq7ncUQPer1/lznPZfW/qwC0oecE8LyW+aAF2IlmTWXKE7CuIcDaTXorc89X9HlMmZRIz4qTVBDZdNEeZx0yJynw75g9O1EV6twIwUPy/q1asOOlT3WObSnzxH2a8Fn9VumMPeJn3nJEx+uEcOE3baN5c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760775720; c=relaxed/simple; bh=8N2CQnoL91rtzoF/Ah0R0Ug8JtQL/qkG5GITjGjzLjQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=hSlQkhr1K6uuyo3dkhMRhG9c7dWQSPMGTq4JBwpm7oCI00d8oPiAxkMGh3B+TLFI0a/WZpykRaSQ88L4CqzRZONgfNxrVncKUph23VPlAlCA/SnCICyhQK1Ujuhv3IxTZbSdfwHWx1f0Snb20sf9oDJOHI+6rFDvlD6aTNOxmoQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4726F3858D2A Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E81B92004E; Sat, 18 Oct 2025 08:21:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1760775719; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/umliET5IUWQYKDXNAkIs6/8AXITrb9wFAxD1kzfBoY=; b=BlXlE69Gr+5zY3HnBVkZeAVuyoFWwTjIL7Rx8Py+XhyUIfDosLtBRe24Hy7CQPaus/8T3T mz+SIOitiRKwQA2M6PAdB/s2mXsK0E8DlxQ3wWI6VBS2k3oY5PzNCvyhRHQ8a/wwRbL3R1 iN9aefKpQ2KQ75JZXIIgDGYFYUkgxM4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1760775719; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/umliET5IUWQYKDXNAkIs6/8AXITrb9wFAxD1kzfBoY=; b=wgbJwRl4MDlFiLjjmBBQ8dmCkkfV/asxUD4qCVch+fHLds4OkmAi/th1sFeRfGxXC/1MtD tudXI/VUqSRBKTAQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uiUbw15Q; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=LpAuNNG1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1760775718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/umliET5IUWQYKDXNAkIs6/8AXITrb9wFAxD1kzfBoY=; b=uiUbw15QQ/EwXCvKTf0CEW5ieoLTnPnyuLqRKw8NfGlOhDy3s+QQF/I1r/wTAD5h0vr/Gi 5n+gLOuFYbY5lzD9/emCx++uHeWlpgWlnqrprIbGvKnGo1pdWWav4dpjV4Y5m78uI6nBSO KBM6oUMK1Xc0wE501WB62vsQTfcRyoo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1760775718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/umliET5IUWQYKDXNAkIs6/8AXITrb9wFAxD1kzfBoY=; b=LpAuNNG1KO5l6o5QrIohaa2qMDcQqGUc619ba8ktMUAct4K5H4Ofuc6JLbtsPGnZaD7bP9 xnh2UOzAB5fYiCCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D1C021386E; Sat, 18 Oct 2025 08:21:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id O5PKMSZO82ifTQAAD6G6ig (envelope-from ); Sat, 18 Oct 2025 08:21:58 +0000 Message-ID: Date: Sat, 18 Oct 2025 10:21:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.tui/resize-3.exp on ppc64-linux To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20251017133957.2464782-1-tdevries@suse.de> <87cy6lr4xw.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87cy6lr4xw.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E81B92004E X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/17/25 4:14 PM, Tom Tromey wrote: > Tom> - "$hex\\s+ Tom> + [string cat $hex {\s+} "<" ([string_to_regexp .])? "foo"] > > Personally I find this a lot less readable than just writing out the > regular expression. How about: ... set re_dot [string_to_regexp "."] set re [string cat $hex {\s+} "<" "($re_dot)?" "foo"] ... Or: ... set re [string cat $hex {\s+} "<" {(\.)?} "foo"] ... I find this style much less readable: ... set re "$hex\\s+<(\\.)?foo" ... That is, I don't understand why you would join logically separate parts of the regexp together and force readers of the regexp to go through the process of separating them out again. It's also error prone, especially where the dot is concerned: - if you forget the second backslash on the s, you get a mismatch and it's easily spotted. - if you forget the second backslash on the dot, you still get a match, but it'll match any character, say the a in "0x00c0ffee ". I've seen many examples of this mistake in the testsuite sources. Thanks, - Tom