From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.tui/resize-3.exp on ppc64-linux
Date: Mon, 20 Oct 2025 12:08:49 +0200 [thread overview]
Message-ID: <cbd57014-b5bf-4f4e-acf2-1c39796b3f4a@suse.de> (raw)
In-Reply-To: <87frbgb01g.fsf@tromey.com>
On 10/18/25 7:19 PM, Tom Tromey wrote:
> Just to ground this discussion a bit, I don't really care about this
> particular test. You can land this patch if you want. I'm not likely
> to ever look at it again. However this is more about the future
> direction of the test suite in general.
I ended up committing:
...
- "$hex\\s+<foo"
+ [subst -nobackslashes -nocommands {$hex\s+<(\.)?foo}]
...
This means the entire string is using a single quoting style. By using
the braces, we get rid of the double escaping mess. And by using
subst, we still interpret the variable despite using braces.
I'm planning to submit a follow-up patch that introduces an alias
subst_vars which would simplify this to:
...
+ [subst_vars {$hex\s+<(\.)?foo}]
...
Thanks,
- Tom
prev parent reply other threads:[~2025-10-20 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 13:39 Tom de Vries
2025-10-17 14:14 ` Tom Tromey
2025-10-18 8:21 ` Tom de Vries
2025-10-18 9:11 ` Tom de Vries
2025-10-18 17:19 ` Tom Tromey
2025-10-20 10:08 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbd57014-b5bf-4f4e-acf2-1c39796b3f4a@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox