From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: use std::vector instead of alloca in core_target::get_core_register_section
Date: Mon, 13 Jan 2020 19:45:00 -0000 [thread overview]
Message-ID: <d3ace394-3fb4-cc05-8409-fa17e53ccd76@redhat.com> (raw)
In-Reply-To: <20200112201729.489317-1-simon.marchi@polymtl.ca>
On 1/12/20 8:17 PM, Simon Marchi wrote:
> - contents = (char *) alloca (size);
> - if (! bfd_get_section_contents (core_bfd, section, contents,
> + std::vector<char> contents (size);
> + if (! bfd_get_section_contents (core_bfd, section, contents.data (),
> (file_ptr) 0, size))
> {
gdb::byte_vector
Thanks,
Pedro Alves
next prev parent reply other threads:[~2020-01-13 19:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 20:22 Simon Marchi
2020-01-13 3:30 ` Christian Biesinger via gdb-patches
2020-01-13 4:29 ` Simon Marchi
2020-01-13 10:45 ` Andreas Schwab
2020-01-13 17:03 ` Simon Marchi
2020-01-13 17:33 ` Tom Tromey
2020-01-13 19:36 ` Simon Marchi
2020-01-13 19:45 ` Pedro Alves [this message]
2020-01-13 20:20 ` Simon Marchi
2020-01-13 23:13 ` Pedro Alves
2020-01-13 23:21 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3ace394-3fb4-cc05-8409-fa17e53ccd76@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox