From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5943 invoked by alias); 13 Jan 2020 19:40:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5935 invoked by uid 89); 13 Jan 2020 19:40:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 19:40:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578944435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FcWQ6vK/8jr5AJKzgRTNmZQnVkSKf4HPdc1MNadub7k=; b=RVCeitlk7xHRhDOiSoN8oCy8kXIK6ENMHisgcjtsw0S261ta/+ht1fxIIoGEKy9k7eKp8w JMQEXhe+5Nc1OujOYyacoCCjyh9+n6ph67LC1JVM7I4BTOzcS8feNbc4j72XPNkr1R60E0 zmcFujwSUKzpdQkqA5kb5foVBolXCEs= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-HVG9vWYeNKCB2EIvpNcyBg-1; Mon, 13 Jan 2020 14:40:32 -0500 Received: by mail-wm1-f72.google.com with SMTP id y125so202211wmg.1 for ; Mon, 13 Jan 2020 11:40:31 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id y20sm15144108wmi.25.2020.01.13.11.40.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2020 11:40:30 -0800 (PST) Subject: Re: [PATCH] gdb: use std::vector instead of alloca in core_target::get_core_register_section To: Simon Marchi , gdb-patches@sourceware.org References: <20200112201729.489317-1-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: Date: Mon, 13 Jan 2020 19:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200112201729.489317-1-simon.marchi@polymtl.ca> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-01/txt/msg00350.txt.bz2 On 1/12/20 8:17 PM, Simon Marchi wrote: > - contents = (char *) alloca (size); > - if (! bfd_get_section_contents (core_bfd, section, contents, > + std::vector contents (size); > + if (! bfd_get_section_contents (core_bfd, section, contents.data (), > (file_ptr) 0, size)) > { gdb::byte_vector Thanks, Pedro Alves