From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: use std::vector instead of alloca in core_target::get_core_register_section
Date: Mon, 13 Jan 2020 17:33:00 -0000 [thread overview]
Message-ID: <87y2ubp8l0.fsf@tromey.com> (raw)
In-Reply-To: <20200112201729.489317-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 12 Jan 2020 15:17:29 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> We are using alloca to hold the contents of a the core register
Simon> sections. These sections are typically fairly small, but there is no
Simon> realy guarantee, so I think it would be more reasonable to just use
Simon> dynamic allocation here.
I would be fine with simply avoiding alloca in most, or all, cases.
Simon> gdb/ChangeLog:
Simon> * corelow.c (core_target::get_core_register_section): Use
Simon> std::vector instead of alloca.
Looks reasonable to me.
Tom
next prev parent reply other threads:[~2020-01-13 17:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 20:22 Simon Marchi
2020-01-13 3:30 ` Christian Biesinger via gdb-patches
2020-01-13 4:29 ` Simon Marchi
2020-01-13 10:45 ` Andreas Schwab
2020-01-13 17:03 ` Simon Marchi
2020-01-13 17:33 ` Tom Tromey [this message]
2020-01-13 19:36 ` Simon Marchi
2020-01-13 19:45 ` Pedro Alves
2020-01-13 20:20 ` Simon Marchi
2020-01-13 23:13 ` Pedro Alves
2020-01-13 23:21 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2ubp8l0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox