From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48981 invoked by alias); 13 Jan 2020 17:30:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48925 invoked by uid 89); 13 Jan 2020 17:30:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.50.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 17:30:54 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 4C382400D1684 for ; Mon, 13 Jan 2020 10:18:48 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id r3YCiCIwbiJ43r3YCiT4a1; Mon, 13 Jan 2020 11:30:52 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=R8NvrzdG1nCQ6EoFINdRNTknEXwm5g2G5NdwK1lSuS8=; b=gb2IaJmD7d10rbQ9SVYs+Zw/QY QCr4MH54rdTduMN4Vy3LSW81U6APlYEY+bOVskt+xUvf0wWTskCtZoujQMMnFvBgpYIO4lM+8bE+H aELdm7vCvgBGB8u1ZuPXxrCLL; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:40992 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ir3YC-000Wno-GG; Mon, 13 Jan 2020 10:30:52 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: use std::vector instead of alloca in core_target::get_core_register_section References: <20200112201729.489317-1-simon.marchi@polymtl.ca> Date: Mon, 13 Jan 2020 17:33:00 -0000 In-Reply-To: <20200112201729.489317-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Sun, 12 Jan 2020 15:17:29 -0500") Message-ID: <87y2ubp8l0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-01/txt/msg00337.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> We are using alloca to hold the contents of a the core register Simon> sections. These sections are typically fairly small, but there is no Simon> realy guarantee, so I think it would be more reasonable to just use Simon> dynamic allocation here. I would be fine with simply avoiding alloca in most, or all, cases. Simon> gdb/ChangeLog: Simon> * corelow.c (core_target::get_core_register_section): Use Simon> std::vector instead of alloca. Looks reasonable to me. Tom