Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Pedro Franco de Carvalho <pedromfc@linux.ibm.com>,
	GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Implement timestamp'ed output on "make check"
Date: Sat, 08 Dec 2018 12:58:00 -0000	[thread overview]
Message-ID: <d394d6e0-6354-6a3a-3655-cbb1784fd7b9@redhat.com> (raw)
In-Reply-To: <87y391xa44.fsf@redhat.com>

On 12/07/2018 10:09 PM, Sergio Durigan Junior wrote:
> On Friday, December 07 2018, Pedro Alves wrote:
> 
>> On 12/06/2018 07:52 PM, Sergio Durigan Junior wrote:
>>> The results can be found at <https://gdb-build.sergiodj.net/results/>,
>>> but you're, you just have access to the consolidated gdb.log, not the
>>> different logs under output/.
>>
>> Given the above, then I have to ask: what's the advantage of the
>> new timestamped output mode?  Why not just extract the info out
>> of the gdb.log file?  It's less code to maintain, and you don't
>> have to remember to run the testsuite in a special mode, nor
>> record stdout of the test run.
> 
> When I was writing the timestamp script, I didn't think about extracting
> the info from gdb.log.  So there's that.  I agree that it's easier to
> have the consolidated info at the end, and I can propose a patch for
> that based on your shell script, 

I think you're missing that we don't even need my previous script.  As Pedro said:

"Still, the merged gdb.log file seems to already have the completion
            ^^^^^^
 times, e.g.:

 testcase [...]gdb.trace/unavailable.exp completed in 28 seconds"


So all we need is something like this:

 $ grep "completed in " testsuite/gdb.log | awk '{print $5 " seconds for " $2}' | sort -n | tail -n 10
 20 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/fork-running-state.exp
 23 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/gnu-ifunc.exp
 28 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/attach-pie-misread.exp
 28 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/foll-vfork.exp
 29 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/attach.exp
 31 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/checkpoint.exp
 32 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/checkpoint-ns.exp
 37 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/dprintf-detach.exp
 49 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/gdb-sigterm.exp
 78 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/break-interp.exp

Thanks,
Pedro Alves


  reply	other threads:[~2018-12-08 12:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 22:12 Sergio Durigan Junior
2018-11-23 14:42 ` Alan Hayward
2018-11-23 15:03 ` [PATCH v2] " Sergio Durigan Junior
2018-11-23 18:23   ` Simon Marchi
2018-11-25 16:24     ` Sergio Durigan Junior
2018-11-25 19:56       ` Simon Marchi
2018-11-25 23:23         ` Sergio Durigan Junior
2018-11-26  0:47           ` Simon Marchi
2018-11-26 16:29             ` Sergio Durigan Junior
2018-11-26 17:22               ` Simon Marchi
2018-11-26 18:48           ` Sergio Durigan Junior
2018-12-05 19:39 ` [PATCH] " Pedro Franco de Carvalho
2018-12-05 19:48   ` Sergio Durigan Junior
     [not found]     ` <87sgzbohzb.fsf@linux.vnet.ibm.com>
2018-12-05 20:26       ` Sergio Durigan Junior
2018-12-06 15:30         ` Pedro Alves
2018-12-06 15:54           ` Pedro Alves
2018-12-06 19:32             ` Pedro Franco de Carvalho
2018-12-06 19:52               ` Sergio Durigan Junior
2018-12-07 20:06                 ` Pedro Alves
2018-12-07 22:09                   ` Sergio Durigan Junior
2018-12-08 12:58                     ` Pedro Alves [this message]
2018-12-08 23:16                       ` Sergio Durigan Junior
2018-12-09  8:57                         ` Philippe Waroquiers
2018-12-06 19:41         ` Pedro Franco de Carvalho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d394d6e0-6354-6a3a-3655-cbb1784fd7b9@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedromfc@linux.ibm.com \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox