Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
	       GDB Patches <gdb-patches@sourceware.org>,
	       Alan Hayward <Alan.Hayward@arm.com>, nd <nd@arm.com>
Subject: Re: [PATCH v2] Implement timestamp'ed output on "make check"
Date: Mon, 26 Nov 2018 00:47:00 -0000	[thread overview]
Message-ID: <5417842c2c8843e89f4390cd052c93a5@polymtl.ca> (raw)
In-Reply-To: <877eh04u8g.fsf@redhat.com>

On 2018-11-25 18:23, Sergio Durigan Junior wrote:
> Ah, OK.  I'm not used to tools that don't ask me whether I'd like to
> modify a file.

The -i switch tells it to modify the file in-place, otherwise it outputs 
on stdout.

> And FWIW, I don't really like this part of PEP8 which
> states that there should be no spaces before parentheses.

If you hate it that much, feel free to propose a change to our standards 
:)

> Anyway, I've pushed the commit now:
> 
>   f63c03b470036353c8c6c657e15f5ebd62ab67dd
> 
> Thanks again for the review.

Thanks,

Simon


  reply	other threads:[~2018-11-26  0:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-22 22:12 [PATCH] " Sergio Durigan Junior
2018-11-23 14:42 ` Alan Hayward
2018-11-23 15:03 ` [PATCH v2] " Sergio Durigan Junior
2018-11-23 18:23   ` Simon Marchi
2018-11-25 16:24     ` Sergio Durigan Junior
2018-11-25 19:56       ` Simon Marchi
2018-11-25 23:23         ` Sergio Durigan Junior
2018-11-26  0:47           ` Simon Marchi [this message]
2018-11-26 16:29             ` Sergio Durigan Junior
2018-11-26 17:22               ` Simon Marchi
2018-11-26 18:48           ` Sergio Durigan Junior
2018-12-05 19:39 ` [PATCH] " Pedro Franco de Carvalho
2018-12-05 19:48   ` Sergio Durigan Junior
     [not found]     ` <87sgzbohzb.fsf@linux.vnet.ibm.com>
2018-12-05 20:26       ` Sergio Durigan Junior
2018-12-06 15:30         ` Pedro Alves
2018-12-06 15:54           ` Pedro Alves
2018-12-06 19:32             ` Pedro Franco de Carvalho
2018-12-06 19:52               ` Sergio Durigan Junior
2018-12-07 20:06                 ` Pedro Alves
2018-12-07 22:09                   ` Sergio Durigan Junior
2018-12-08 12:58                     ` Pedro Alves
2018-12-08 23:16                       ` Sergio Durigan Junior
2018-12-09  8:57                         ` Philippe Waroquiers
2018-12-06 19:41         ` Pedro Franco de Carvalho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5417842c2c8843e89f4390cd052c93a5@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=Alan.Hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=sergiodj@redhat.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox