From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53351 invoked by alias); 8 Dec 2018 12:58:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53341 invoked by uid 89); 8 Dec 2018 12:58:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 08 Dec 2018 12:58:45 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7539C30917A6; Sat, 8 Dec 2018 12:58:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 939BB5C1A1; Sat, 8 Dec 2018 12:58:41 +0000 (UTC) Subject: Re: [PATCH] Implement timestamp'ed output on "make check" To: Sergio Durigan Junior References: <87va47ojas.fsf@linux.vnet.ibm.com> <87a7ljdaax.fsf@redhat.com> <87sgzbohzb.fsf@linux.vnet.ibm.com> <87efavbu02.fsf@redhat.com> <7d58b34f-3082-a266-7f38-79e4f80a533c@redhat.com> <5ca80f12-c329-ac40-f6a9-eb8f2b71cceb@redhat.com> <87sgzao3ib.fsf@linux.vnet.ibm.com> <87o99y301i.fsf@redhat.com> <99703054-f538-0300-2d7b-83c31357f563@redhat.com> <87y391xa44.fsf@redhat.com> Cc: Pedro Franco de Carvalho , GDB Patches From: Pedro Alves Message-ID: Date: Sat, 08 Dec 2018 12:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <87y391xa44.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-12/txt/msg00104.txt.bz2 On 12/07/2018 10:09 PM, Sergio Durigan Junior wrote: > On Friday, December 07 2018, Pedro Alves wrote: > >> On 12/06/2018 07:52 PM, Sergio Durigan Junior wrote: >>> The results can be found at , >>> but you're, you just have access to the consolidated gdb.log, not the >>> different logs under output/. >> >> Given the above, then I have to ask: what's the advantage of the >> new timestamped output mode? Why not just extract the info out >> of the gdb.log file? It's less code to maintain, and you don't >> have to remember to run the testsuite in a special mode, nor >> record stdout of the test run. > > When I was writing the timestamp script, I didn't think about extracting > the info from gdb.log. So there's that. I agree that it's easier to > have the consolidated info at the end, and I can propose a patch for > that based on your shell script, I think you're missing that we don't even need my previous script. As Pedro said: "Still, the merged gdb.log file seems to already have the completion ^^^^^^ times, e.g.: testcase [...]gdb.trace/unavailable.exp completed in 28 seconds" So all we need is something like this: $ grep "completed in " testsuite/gdb.log | awk '{print $5 " seconds for " $2}' | sort -n | tail -n 10 20 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/fork-running-state.exp 23 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/gnu-ifunc.exp 28 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/attach-pie-misread.exp 28 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/foll-vfork.exp 29 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/attach.exp 31 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/checkpoint.exp 32 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/checkpoint-ns.exp 37 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/dprintf-detach.exp 49 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/gdb-sigterm.exp 78 seconds for /home/pedro/gdb/binutils-gdb/src/gdb/testsuite/gdb.base/break-interp.exp Thanks, Pedro Alves