From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/6] gdbsupport: add async parallel_for_each version
Date: Fri, 13 Jun 2025 15:29:01 -0400 [thread overview]
Message-ID: <d26275d4-c14e-4340-85be-d3faf60fe341@polymtl.ca> (raw)
In-Reply-To: <87ldpvjxjd.fsf@tromey.com>
On 6/13/25 2:39 PM, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
>
> Simon> +/* If enabled, print debug info about the inner workings of the parallel for
> Simon> + each functions. */
> Simon> +const bool parallel_for_each_debug = false;
>
> Defining a global in a header makes me itch a little.
> I feel like we've had linker problems with this somewhere?
> Anyway couldn't this be constexpr?
I don't recall. Doesn't the linker choose just one version of the
variable, ODR-style?
I can certainly make it constexpr, if that helps.
Simon
next prev parent reply other threads:[~2025-06-13 19:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 20:15 [PATCH 1/6] gdb: re-work parallel-for-selftests.c Simon Marchi
2025-05-05 20:15 ` [PATCH 2/6] gdbsupport: make gdb::parallel_for_each's n parameter a template parameter Simon Marchi
2025-06-13 17:55 ` Tom Tromey
2025-06-13 18:43 ` Simon Marchi
2025-05-05 20:15 ` [PATCH 3/6] gdbsupport: use dynamic partitioning in gdb::parallel_for_each Simon Marchi
2025-06-13 18:29 ` Tom Tromey
2025-06-13 19:22 ` Simon Marchi
2025-06-13 19:56 ` Simon Marchi
2025-06-13 20:12 ` Simon Marchi
2025-06-26 19:27 ` Simon Marchi
2025-07-03 19:23 ` Tom Tromey
2025-07-03 19:36 ` Simon Marchi
2025-05-05 20:15 ` [PATCH 4/6] gdbsupport: factor out work queue from parallel-for.h Simon Marchi
2025-06-13 18:33 ` Tom Tromey
2025-06-13 19:24 ` Simon Marchi
2025-05-05 20:15 ` [PATCH 5/6] gdbsupport: add async parallel_for_each version Simon Marchi
2025-06-13 18:39 ` Tom Tromey
2025-06-13 19:29 ` Simon Marchi [this message]
2025-05-05 20:15 ` [PATCH 6/6] gdb/dwarf: use dynamic partitioning for DWARF CU indexing Simon Marchi
2025-05-27 14:44 ` [PATCH 1/6] gdb: re-work parallel-for-selftests.c Simon Marchi
2025-06-13 17:48 ` Tom Tromey
2025-06-13 18:38 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26275d4-c14e-4340-85be-d3faf60fe341@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox