From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8dEeBSp8TGje4wwAWB0awg (envelope-from ) for ; Fri, 13 Jun 2025 15:29:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=M94augTh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F2C151E102; Fri, 13 Jun 2025 15:29:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7E8BC1E0C2 for ; Fri, 13 Jun 2025 15:29:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2093F380ED36 for ; Fri, 13 Jun 2025 19:29:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2093F380ED36 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=default header.b=M94augTh Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 889F9380ED04 for ; Fri, 13 Jun 2025 19:29:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 889F9380ED04 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 889F9380ED04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749842948; cv=none; b=ZzdJ2sed+liDdPDgxRXMS9D0cf2tELBEJ1OTiB+T5JR58Mqcghn/VDlwOc/uWmmxy74AvsmxTWWD8sD2Jdy3ygyfDiVUdSiRPNgu2IKF4WuTDvQbNH8p/ifM8JsoX4sJZa1n416DZ8B5s1yoXvn1osEUfb55ETkBsC/P53pUGvk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1749842948; c=relaxed/simple; bh=y9NtqxNOTn4+PZWwoE7Xwl/xcGmCFWtyEf5uXsP57UA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=nTJY7TesH3HMMBZjBJIRo8qjuyn09sML+JlrUSxijzkkNK9BpTPb1QsQvoN2tpD3p4OC1usUz7EoL1f3HM471aMUKmcMX7kasx0swpsdmdE+THADbIKrOmrvAb6bEEi9/rjDkJmpHG0QK04H0qBf//yPTw1sH1M8KlPJzKFzy9U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 889F9380ED04 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 55DJT3UX048251 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Jun 2025 15:29:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 55DJT3UX048251 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1749842948; bh=ArrFbvWD5OBMKZuHgOJkDfkPyvZeL7Ye2d6CD5Rqg8Q=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=M94augThOlQTWeBZfzkGxHzNZezB9eq1T85s0B6Eieiu0xDQClXCF5Yrn2BfQCNAa aM662lRc24rWp8euOib2HR/yKFwByOux+n36apTCCrMD9pTkVz9bAVEDcFVFWOxffz MAsadWSQAeqz1z1dg8v47YChlj1FECoLWW5F54i8= Received: by simark.ca (Postfix, from userid 112) id 5BC661E126; Fri, 13 Jun 2025 15:29:03 -0400 (EDT) Received: from [172.16.0.192] (192-222-132-26.qc.cable.ebox.net [192.222.132.26]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C6EE41E0C2; Fri, 13 Jun 2025 15:29:01 -0400 (EDT) Message-ID: Date: Fri, 13 Jun 2025 15:29:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/6] gdbsupport: add async parallel_for_each version To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <20250505201548.184917-1-simon.marchi@efficios.com> <20250505201548.184917-5-simon.marchi@efficios.com> <87ldpvjxjd.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87ldpvjxjd.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 13 Jun 2025 19:29:03 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/13/25 2:39 PM, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> +/* If enabled, print debug info about the inner workings of the parallel for > Simon> + each functions. */ > Simon> +const bool parallel_for_each_debug = false; > > Defining a global in a header makes me itch a little. > I feel like we've had linker problems with this somewhere? > Anyway couldn't this be constexpr? I don't recall. Doesn't the linker choose just one version of the variable, ODR-style? I can certainly make it constexpr, if that helps. Simon