From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 3/6] gdbsupport: use dynamic partitioning in gdb::parallel_for_each
Date: Thu, 03 Jul 2025 13:23:05 -0600 [thread overview]
Message-ID: <87plehulie.fsf@tromey.com> (raw)
In-Reply-To: <3a7fcb84-773c-4c08-ac59-23bd6e5a508e@simark.ca> (Simon Marchi's message of "Thu, 26 Jun 2025 15:27:49 -0400")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Sorry for the delay on this. My time is split these days and so I'm not
keeping up with gdb quite as frequently.
Simon> I have thought about this problem some more, and I discussed this with
Simon> my team. I still think that the functor approach is the only one that
Simon> relatively cleanly meets the various requirements:
Simon> - be able to run a per-worker initialize step
Simon> - be able to keep some per-worker data for the duration of the for-each
Simon> - be able to run a per-worker finalize step
IMO let's just go with your original plan. It seems clear &
straightforward. I don't like the wordiness so much but I tend to think
the other alternatives are less clear.
This seems like another area that coroutines would clear up. I have
high hopes for those removing a lot of extraneous classes and turning
them into local variables. No idea when we can adopt C++20 though.
Tom
next prev parent reply other threads:[~2025-07-03 19:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 20:15 [PATCH 1/6] gdb: re-work parallel-for-selftests.c Simon Marchi
2025-05-05 20:15 ` [PATCH 2/6] gdbsupport: make gdb::parallel_for_each's n parameter a template parameter Simon Marchi
2025-06-13 17:55 ` Tom Tromey
2025-06-13 18:43 ` Simon Marchi
2025-05-05 20:15 ` [PATCH 3/6] gdbsupport: use dynamic partitioning in gdb::parallel_for_each Simon Marchi
2025-06-13 18:29 ` Tom Tromey
2025-06-13 19:22 ` Simon Marchi
2025-06-13 19:56 ` Simon Marchi
2025-06-13 20:12 ` Simon Marchi
2025-06-26 19:27 ` Simon Marchi
2025-07-03 19:23 ` Tom Tromey [this message]
2025-07-03 19:36 ` Simon Marchi
2025-05-05 20:15 ` [PATCH 4/6] gdbsupport: factor out work queue from parallel-for.h Simon Marchi
2025-06-13 18:33 ` Tom Tromey
2025-06-13 19:24 ` Simon Marchi
2025-05-05 20:15 ` [PATCH 5/6] gdbsupport: add async parallel_for_each version Simon Marchi
2025-06-13 18:39 ` Tom Tromey
2025-06-13 19:29 ` Simon Marchi
2025-05-05 20:15 ` [PATCH 6/6] gdb/dwarf: use dynamic partitioning for DWARF CU indexing Simon Marchi
2025-05-27 14:44 ` [PATCH 1/6] gdb: re-work parallel-for-selftests.c Simon Marchi
2025-06-13 17:48 ` Tom Tromey
2025-06-13 18:38 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plehulie.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox