From: Guinevere Larsen <guinevere@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/record: fix "maint print record-instruction" at the start of log
Date: Wed, 2 Sep 2026 11:20:17 -0300 [thread overview]
Message-ID: <d1ddad22-f4cf-478e-af0f-2d271f18419e@redhat.com> (raw)
In-Reply-To: <87ecfc7vxr.fsf@tromey.com>
On 9/1/26 1:55 PM, Tom Tromey wrote:
>>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:
> Guinevere> Caused a regression where, if a user was at the start of the record
> Guinevere> history and used the command "maint print record-instruction", GDB
> Guinevere> would throw an internal error for trying to print an out-of-bounds
> Guinevere> record. This commit fixes this by making the check for out of bounds
> Guinevere> printing independent of an argument being supplied.
>
> Looks reasonable to me.
> Approved-By: Tom Tromey <tom@tromey.com>
Thanks for the quick review, pushed!
> thanks,
> Tom
>
--
Cheers,
Guinevere Larsen
it/its
she/her (deprecated)
prev parent reply other threads:[~2026-09-02 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 14:33 Guinevere Larsen
2026-09-01 16:55 ` Tom Tromey
2026-09-02 14:20 ` Guinevere Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ddad22-f4cf-478e-af0f-2d271f18419e@redhat.com \
--to=guinevere@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox