From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +rJYLsMwmGo4CR8AWB0awg (envelope-from ) for ; Wed, 02 Sep 2026 10:20:51 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hPoUl8wg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A3AEB1E033; Wed, 02 Sep 2026 10:20:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 87E4A1E033 for ; Wed, 02 Sep 2026 10:20:50 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 73B314BA2E25 for ; Wed, 2 Sep 2026 14:20:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73B314BA2E25 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hPoUl8wg Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id A55B74BA2E19 for ; Wed, 2 Sep 2026 14:20:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A55B74BA2E19 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A55B74BA2E19 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788358824; cv=none; b=E6tdySMKhw/fNg1HJEHCw2dAey8mA8hvHr7ylvRP63npDNXd/RWQPgdEWW8s13Su+aUc/WROAFZJkteD9CN7muhjeyHijylHQsTTgduqO7fwdJ47CX6DgyBotfuXK1ocbRUh33Tg+KY1QAQhEnJdDVT2CEMQbEuI5oyKbQtCjD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788358824; c=relaxed/simple; bh=Ilp3dWyJ1wbKAfpB3/VPklz8W2m2iQIp30a6786f4lA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=M6LNRIRd8eIlsFwij2b0YwBGPjx/Y090njyK6zgXIR7doxY+xDrbZu6BJ93tbx1vKR7wymg9uyRTGooYIuV3ZPRSNLMOpN6b9Rw+qJxymPROpybhcW9btcD3q6V7aWMI1dOhy9ox9DcVcZFEgIPR82JoM06hhGOj3kOr968Ic64= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hPoUl8wg DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A55B74BA2E19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788358824; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SYt8AB+aoxNMhOVPOSlxyfkYd4WMeFqXwDtBWcTVwpU=; b=hPoUl8wgI0zLOAGE/dpp+/KW7QNCSzf2yS0dSUEutWWNJR/bYDgUfXJTkxUDgtyh7kNMP5 +xPhrPwLCWIKc81DfIcHm3Ky/pRSJ3yWrUB6vRMsRKzS09cgM4iOD+rNwezwcdo6Ws/mSN zbSeTcbu8oJHz6D9O7mj6JsZynPOJwc= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-6UMHraN5NCm1MFXc7Cc-nw-1; Wed, 02 Sep 2026 10:20:22 -0400 X-MC-Unique: 6UMHraN5NCm1MFXc7Cc-nw-1 X-Mimecast-MFC-AGG-ID: 6UMHraN5NCm1MFXc7Cc-nw_1788358822 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-936e393061dso173036585a.2 for ; Wed, 02 Sep 2026 07:20:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788358822; x=1788963622; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SYt8AB+aoxNMhOVPOSlxyfkYd4WMeFqXwDtBWcTVwpU=; b=sKoNW0UyeLwvRGu+sQLYHrxmOG7rejFM1juN3v83rR8vvRCoIRxlHEOE3yFzwy+wqJ TxxJqNdkr1jCaRwl0HH6BSKZWaKJm4/tW8kQA2fxVB8bFu+rOoIZPgdcpe3g+fKqkfv+ eOLf+U73+H8hFehrQSaxrSaCrDYLO3cH4AZl/x8hJJRF2SpeZ1t4+KLxx9pLCiNuRU0f 1iejqB+pV+w/RY+DWXNSSu1q7qp0YRS6FZeNNHEWqJUNN4ivIMBG8thXCE+vVu1uBn7u z1nNXhAP0AFdCxMeM4x9z5Ue7MtnmGfBt8Pb9PfJP7w7lynilnammxlM520X7kjXAXDI eN4g== X-Gm-Message-State: AFuF++njHZtN/iBvsdSC21zesVZ0XJvyUitQV6o5HzhpPdHuXNuytPGL KE5iUo48DE8EN2+DZ+T9tzbDv5NYv/bP+TTy3euR/ZeUX9msxtVxNtWC+wqpKzkDgCNgL71V5J0 sEWyEKy85CTYQ3IyRyvd8+kg9yP0gonghZoyTFxpZgZgbkXT9trRxvp+R4Ucm1xvqHpD132k= X-Gm-Gg: AR+sD12qJVLL+uzlvzyEeT+pVzQ1ObTzu3YUjxFWgA35J4iqiSYypZwUCSEYXRJ1sY/ XJyIa7aA85kcQzZYWCQgNNQOM/VTsvXjqXpwOM5GM9uiFXf9YlrJ3FjPQGAcU8VBMopgNIyzMRM UwOdyRqPKH6NdjxSHsQV8XuX0HkaeT3jYKFuZ4hXGEiEuiY1kBlEqLFV/jkk74L50k3vmjJPWOE lhJxCBzoXIFH/UHeX6IZye012FuC370P3nl55dKadJQpqgFR9csYP/FwNwO/hG1JELQjexgonHF hYfET95RhztgvCEFW+WmJzvI74y5oKcjain9aV0p33GMeZK7WrJaqiblUmfEDUg6qS1i94lPDGd eCkay9HClh+bjA3W9wmOoBpiX7Fu+Ffayaacpsu+Vmy5mfivGGQ== X-Received: by 2002:a05:620a:31a1:b0:939:6d22:6fd with SMTP id af79cd13be357-9396d2208a1mr17376585a.18.1788358822102; Wed, 02 Sep 2026 07:20:22 -0700 (PDT) X-Received: by 2002:a05:620a:31a1:b0:939:6d22:6fd with SMTP id af79cd13be357-9396d2208a1mr17360685a.18.1788358821371; Wed, 02 Sep 2026 07:20:21 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e:22e8:4ed1:527a:55c0? ([2804:14d:8084:993e:22e8:4ed1:527a:55c0]) by smtp.gmail.com with ESMTPSA id af79cd13be357-9395f186f5esm220436485a.13.2026.09.02.07.20.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2026 07:20:20 -0700 (PDT) Message-ID: Date: Wed, 2 Sep 2026 11:20:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/record: fix "maint print record-instruction" at the start of log To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260901143316.42661-1-guinevere@redhat.com> <87ecfc7vxr.fsf@tromey.com> From: Guinevere Larsen In-Reply-To: <87ecfc7vxr.fsf@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HWF1ZeR46j9-X4CWdhWBftwiOSOjfPT2G5xrvCuB0GM_1788358822 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/1/26 1:55 PM, Tom Tromey wrote: >>>>>> "Guinevere" == Guinevere Larsen writes: > Guinevere> Caused a regression where, if a user was at the start of the record > Guinevere> history and used the command "maint print record-instruction", GDB > Guinevere> would throw an internal error for trying to print an out-of-bounds > Guinevere> record. This commit fixes this by making the check for out of bounds > Guinevere> printing independent of an argument being supplied. > > Looks reasonable to me. > Approved-By: Tom Tromey Thanks for the quick review, pushed! > thanks, > Tom > -- Cheers, Guinevere Larsen it/its she/her (deprecated)