Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/record: fix "maint print record-instruction" at the start of log
Date: Tue, 01 Sep 2026 10:55:44 -0600	[thread overview]
Message-ID: <87ecfc7vxr.fsf@tromey.com> (raw)
In-Reply-To: <20260901143316.42661-1-guinevere@redhat.com> (Guinevere Larsen's message of "Tue, 1 Sep 2026 11:33:16 -0300")

>>>>> "Guinevere" == Guinevere Larsen <guinevere@redhat.com> writes:

Guinevere> Caused a regression where, if a user was at the start of the record
Guinevere> history and used the command "maint print record-instruction", GDB
Guinevere> would throw an internal error for trying to print an out-of-bounds
Guinevere> record. This commit fixes this by making the check for out of bounds
Guinevere> printing independent of an argument being supplied.

Looks reasonable to me.
Approved-By: Tom Tromey <tom@tromey.com>

thanks,
Tom

  reply	other threads:[~2026-09-01 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 14:33 Guinevere Larsen
2026-09-01 16:55 ` Tom Tromey [this message]
2026-09-02 14:20   ` Guinevere Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ecfc7vxr.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guinevere@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox