From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QfuXHLIDl2pMaBsAWB0awg (envelope-from ) for ; Tue, 01 Sep 2026 12:56:18 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AyEa4Y1u; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5B62E1E033; Tue, 01 Sep 2026 12:56:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C4B8F1E033 for ; Tue, 01 Sep 2026 12:56:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9AB234BA2E27 for ; Tue, 1 Sep 2026 16:56:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9AB234BA2E27 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AyEa4Y1u Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id DA6E34BA2E0C for ; Tue, 1 Sep 2026 16:55:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA6E34BA2E0C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DA6E34BA2E0C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788281748; cv=none; b=jUqrCLXFnC8pqcRrKvFnq57cE8tKcn63MDAhsGZ4/y2uFI1eQW7HMqn5ZfBntzCGbf3rFFiU3SbXeap3Z/lYzmPXABEbouZPdMi7N/rnB5OThiHnAHf2rRN7Yfbd0w1peIxBhoVqqnx+Jlx4UxIIK3v6L3gbKwPDf3IXfk+WpwY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788281748; c=relaxed/simple; bh=8ipkyND1ejFaf+u9+NEguKPG3S+BXWgInSRDR39ap/Q=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kpb8bFmq4/M2GvJNcMVjRIqzVcvQOnXd2NbqBLu6GT+NTO3i8A+cRD/Uey8Pi1VlSemHmYUjPASG6OmtONixTjbAhR0Z5kb5nzbRrx1TPLwAryZwRzWBCIRh/JQ9nLYIHaJ7pnBHQ99odGeCQeVM3GcyHCaARTOYSC2aqObGALI= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=AyEa4Y1u reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA6E34BA2E0C Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id 1Oatx47olusRS1RlyxgZ9X; Tue, 01 Sep 2026 16:55:46 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 1RlyxyGl6gxfo1RlyxdxzA; Tue, 01 Sep 2026 16:55:46 +0000 X-Authority-Analysis: v=2.4 cv=B7G50PtM c=1 sm=1 tr=0 ts=6a970392 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=VdqzKS8jKosA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=2PUN1HFjQUXSG6m7V48A:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=8ipkyND1ejFaf+u9+NEguKPG3S+BXWgInSRDR39ap/Q=; b=AyEa4Y1uZ1by0sH0CuotBiMmbM 2/qfbrPHOhy+l86W3s+KkAH8cW+ThKBc9meX1MHbP9n3Rthv5nSxEUsyC9zj6G4cIvuUATEaYml5V FWcKh6FvVSAJe69X4LXtSxsm3; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:54918 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1x1Rlx-00000003HvG-2nNw; Tue, 01 Sep 2026 10:55:45 -0600 From: Tom Tromey To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/record: fix "maint print record-instruction" at the start of log In-Reply-To: <20260901143316.42661-1-guinevere@redhat.com> (Guinevere Larsen's message of "Tue, 1 Sep 2026 11:33:16 -0300") References: <20260901143316.42661-1-guinevere@redhat.com> X-Attribution: Tom Date: Tue, 01 Sep 2026 10:55:44 -0600 Message-ID: <87ecfc7vxr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1x1Rlx-00000003HvG-2nNw X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:54918 X-Source-Auth: tom+tromey.com X-Email-Count: 25 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPCr/wSOjXh/6tB2Q2TR0VCdFrD6PpQPKhiEa14RfsIcdumzrck9r1pCmXTbyOx7Q7ShX1LT3IeLgMxPZbcjJYYs/EvPfOHtqM5tP8zTI+kuvEumVl1i F385OcoCFP+Z38jw2ibXA94TNidbNUtlAMIrc9fZ/kdy4I6dhPRa2p8SApvMdhj/YZ6PnYf0TbN937p7X9xsRXKVvlBZAbZlWP0= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Guinevere" == Guinevere Larsen writes: Guinevere> Caused a regression where, if a user was at the start of the record Guinevere> history and used the command "maint print record-instruction", GDB Guinevere> would throw an internal error for trying to print an out-of-bounds Guinevere> record. This commit fixes this by making the check for out of bounds Guinevere> printing independent of an argument being supplied. Looks reasonable to me. Approved-By: Tom Tromey thanks, Tom