Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp
Date: Fri, 20 Jan 2017 15:25:00 -0000	[thread overview]
Message-ID: <d1b2f240-5d39-ed03-1628-2996f1da531d@redhat.com> (raw)
In-Reply-To: <1484923045-16703-1-git-send-email-lgustavo@codesourcery.com>

On 01/20/2017 02:37 PM, Luis Machado wrote:
> Some leftover uppercase test names in py-xmethods.exp.  The patch also
> replaces two "continue" calls with untested calls to make things a bit more
> clear.
> 
> gdb/testsuite/ChangeLog:
> 
> 2017-01-20  Luis Machado  <lgustavo@codesourcery.com>
> 
> 	* gdb.python/py-xmethods.exp: Fix test names starting with lowercase
> 	and add untested calls.
> ---
>  gdb/testsuite/gdb.python/py-xmethods.exp | 44 +++++++++++++++++---------------
>  1 file changed, 24 insertions(+), 20 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.python/py-xmethods.exp b/gdb/testsuite/gdb.python/py-xmethods.exp
> index 8f5bf16..38b5998 100644
> --- a/gdb/testsuite/gdb.python/py-xmethods.exp
> +++ b/gdb/testsuite/gdb.python/py-xmethods.exp
> @@ -18,7 +18,9 @@
>  
>  load_lib gdb-python.exp
>  
> -if { [skip_cplus_tests] } { continue }
> +if { [skip_cplus_tests] } {
> +    untested "skipping C++ tests"
> +}

We still need something that makes the test
actually be skipped.

Thanks,
Pedro Alves


  reply	other threads:[~2017-01-20 15:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 14:37 Luis Machado
2017-01-20 15:25 ` Pedro Alves [this message]
2017-01-20 15:30   ` Luis Machado
2017-01-20 15:34     ` Pedro Alves
2017-01-20 15:43       ` Luis Machado
2017-01-20 16:45         ` Pedro Alves
2017-01-20 20:00           ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1b2f240-5d39-ed03-1628-2996f1da531d@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lgustavo@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox