From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85223 invoked by alias); 20 Jan 2017 15:25:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84983 invoked by uid 89); 20 Jan 2017 15:24:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Jan 2017 15:24:48 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE0153D974; Fri, 20 Jan 2017 15:24:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0KFOkeq008151; Fri, 20 Jan 2017 10:24:47 -0500 Subject: Re: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp To: Luis Machado , gdb-patches@sourceware.org References: <1484923045-16703-1-git-send-email-lgustavo@codesourcery.com> From: Pedro Alves Message-ID: Date: Fri, 20 Jan 2017 15:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1484923045-16703-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00416.txt.bz2 On 01/20/2017 02:37 PM, Luis Machado wrote: > Some leftover uppercase test names in py-xmethods.exp. The patch also > replaces two "continue" calls with untested calls to make things a bit more > clear. > > gdb/testsuite/ChangeLog: > > 2017-01-20 Luis Machado > > * gdb.python/py-xmethods.exp: Fix test names starting with lowercase > and add untested calls. > --- > gdb/testsuite/gdb.python/py-xmethods.exp | 44 +++++++++++++++++--------------- > 1 file changed, 24 insertions(+), 20 deletions(-) > > diff --git a/gdb/testsuite/gdb.python/py-xmethods.exp b/gdb/testsuite/gdb.python/py-xmethods.exp > index 8f5bf16..38b5998 100644 > --- a/gdb/testsuite/gdb.python/py-xmethods.exp > +++ b/gdb/testsuite/gdb.python/py-xmethods.exp > @@ -18,7 +18,9 @@ > > load_lib gdb-python.exp > > -if { [skip_cplus_tests] } { continue } > +if { [skip_cplus_tests] } { > + untested "skipping C++ tests" > +} We still need something that makes the test actually be skipped. Thanks, Pedro Alves