From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix uppercase test names in gdb.python/py-xmethods.exp
Date: Fri, 20 Jan 2017 16:45:00 -0000 [thread overview]
Message-ID: <4b4b1baa-a8fd-25f0-1f5b-a4cd66cc3118@redhat.com> (raw)
In-Reply-To: <c1976385-0d7f-5389-f01b-d17ffd45480c@codesourcery.com>
On 01/20/2017 03:43 PM, Luis Machado wrote:
>> There's an "unsupported" call inside skip_python_tests.
>
> Hmm, i was working under the assumption this was a flag.
Yeah, it's surprising. I wouldn't mind removing it. Maybe
make it a "verbose" call instead.
> In this case it
> would make sense to handle all of these checks in the same way and not
> add untested calls, making everything standard.
> I can work on that, but should we drop adding any untested calls in this
> particular patch and only return (until a follow on patch)?
I gave it a second thought, and it's fine with me to add the
untested call, despite the UNSUPPORTED already present in gdb.sum.
Patch is OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-01-20 16:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 14:37 Luis Machado
2017-01-20 15:25 ` Pedro Alves
2017-01-20 15:30 ` Luis Machado
2017-01-20 15:34 ` Pedro Alves
2017-01-20 15:43 ` Luis Machado
2017-01-20 16:45 ` Pedro Alves [this message]
2017-01-20 20:00 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b4b1baa-a8fd-25f0-1f5b-a4cd66cc3118@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox