Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tom@tromey.com>
Subject: [PATCHv2 0/2] Address issues with auto-load safe path checking
Date: Wed, 28 Oct 2026 11:40:55 +0000	[thread overview]
Message-ID: <cover.1793187406.git.aburgess@redhat.com> (raw)
In-Reply-To: <878q3oqmzp.fsf@tromey.com>

Tom,

You were right to ask for tests.  As is too often the case, as I wrote
the tests I ran into another bug in the same area, so now there are
two patches.

The first patch is new and addresses an existing bug which would cause
legitimate files to be rejected in some edge cases.

The second patch is the same code as you saw before (with a tweak to
the comment in observable.h), with the test from patch #1 extended to
cover this case too.

Thanks,
Andrew

---

Andrew Burgess (2):
  gdb: check auto-load safe path after refreshing cached vector
  gdb: add debug_file_directory changed observer

 gdb/auto-load.c                               |  20 ++-
 gdb/observable.c                              |   1 +
 gdb/observable.h                              |   4 +
 gdb/symfile.c                                 |  12 +-
 .../auto-load-after-debug-dir-change-1.gdb    |  17 +++
 .../auto-load-after-debug-dir-change-2.gdb    |  17 +++
 .../auto-load-after-debug-dir-change.exp      | 124 ++++++++++++++++++
 7 files changed, 190 insertions(+), 5 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/auto-load-after-debug-dir-change-1.gdb
 create mode 100644 gdb/testsuite/gdb.base/auto-load-after-debug-dir-change-2.gdb
 create mode 100644 gdb/testsuite/gdb.base/auto-load-after-debug-dir-change.exp


base-commit: b2fe3a449cb5d130ea2fec65bb214601826cdeff
-- 
2.25.4


  reply	other threads:[~2026-10-28 11:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 21:47 [PATCH] gdb: add debug_file_directory changed observer Andrew Burgess
2026-10-23 18:40 ` Tom Tromey
2026-10-28 11:40   ` Andrew Burgess [this message]
2026-10-28 11:40     ` [PATCHv2 1/2] gdb: check auto-load safe path after refreshing cached vector Andrew Burgess
2026-10-28 11:40     ` [PATCHv2 2/2] gdb: add debug_file_directory changed observer Andrew Burgess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1793187406.git.aburgess@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox