From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: add debug_file_directory changed observer
Date: Fri, 23 Oct 2026 12:40:26 -0600 [thread overview]
Message-ID: <878q3oqmzp.fsf@tromey.com> (raw)
In-Reply-To: <c427b6f134fd6b366103354300f7df1bc0a2ea4c.1792619245.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 21 Oct 2026 22:47:54 +0100")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> Add a new observer gdb::observers::gdb_debugdir_changed, this is
Andrew> triggered whenever the debug_file_directory is updated.
Andrew> This new observer is analogous to the existing gdb_datadir_changed
Andrew> observer.
The code looks good to me but I wonder if a test is possible and/or
appropriate; at least without undue effort.
Tom
next prev parent reply other threads:[~2026-10-23 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 21:47 Andrew Burgess
2026-10-23 18:40 ` Tom Tromey [this message]
2026-10-28 11:40 ` [PATCHv2 0/2] Address issues with auto-load safe path checking Andrew Burgess
2026-10-28 11:40 ` [PATCHv2 1/2] gdb: check auto-load safe path after refreshing cached vector Andrew Burgess
2026-10-28 11:40 ` [PATCHv2 2/2] gdb: add debug_file_directory changed observer Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878q3oqmzp.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox