From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WfPaKaLf4WrtNj0AWB0awg (envelope-from ) for ; Wed, 28 Oct 2026 07:42:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hrYiqpEu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A5B2B378003; Wed, 28 Oct 2026 07:42:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 19EBE378002 for ; Wed, 28 Oct 2026 07:42:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 49F1E4BA2E1A for ; Wed, 28 Oct 2026 11:42:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 49F1E4BA2E1A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hrYiqpEu Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id B3C144BA2E1C for ; Wed, 28 Oct 2026 11:41:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3C144BA2E1C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B3C144BA2E1C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793187664; cv=none; b=jbMvelLqW61Gplcc566nfcvebGIdQE0hV9aRQmtyuCKLLkZB92pyr7AjshbhbwGXcPRHp0yaSLR3XkQlrNHxRSyon1KEISJFB43OYFLkwneCCMojzBCIQ8t6knIQFybnkQRDcDSZu3WvedqpHrRY9aQ8xdzFB5R4JxUnF//zi6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1793187664; c=relaxed/simple; bh=+GRFOzb5YY/F44FYJpjy1OjK1U8lJXQ8hTKcbc7wyNM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=UGHOeIkdvwG1FT0441pLuJoLo9yu6jIsqJ/uxyRmMD4vAGoYPFvYJTe+EShUgPTH3hwqxPPKgbywMFxK7hP2CPFQor+4F8OmmErt8u0Kk8BJWt+LmK7Qile7lBlWOJvZ6r0/g/ejk/k2gapN+/nTRZMKrVaHtYeCBP3gNAPMdts= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hrYiqpEu DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B3C144BA2E1C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793187664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PP7rtlJqKIkaWpF8UJv7L8s9/Xj3V9Z5eyQXwIi6c/Y=; b=hrYiqpEuBOLPTbqo4R6EBuIgdZemNmXWaJPy4C1LC6l0ZIiX14m/8F0ga1H7/sw/F6iIN/ TXN7hMnusN8CUOk2BmI4jPn7+MtzwjYLD2PF+61Fe1Hc/7bugTDcuf9B2IJJkLRx1XCXqt ++rm0rv9uMBch5FSUvZ1ppjmdD9yXwc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-39-dZFqc9WcPg-R3woG8DD09g-1; Wed, 28 Oct 2026 07:41:03 -0400 X-MC-Unique: dZFqc9WcPg-R3woG8DD09g-1 X-Mimecast-MFC-AGG-ID: dZFqc9WcPg-R3woG8DD09g_1793187662 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49febef74e3so13016485e9.0 for ; Wed, 28 Oct 2026 04:41:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793187662; x=1793792462; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=PP7rtlJqKIkaWpF8UJv7L8s9/Xj3V9Z5eyQXwIi6c/Y=; b=fdI6QKpa1h2BxGVn7XC2cKvw9IU8jOQNlmV+ZEDWA55lRgapAk8y+P+virhkL/FEtC m+5wAk7MxrKcreE1Tf6JNXtWIovmRfjWFQ7c2k4DH7FxBo34kHsbSndDR8vRokNa0f83 3hOfrItvtj5QL9plQrWwGwM+JsOcJlDVctpRphZM0OCgEbJDdxV9pH90QdnTSvzGAE8W AK8tGsaGdiTxbIt9avHTvLCjt/ubPXDBNegoH6cQnjaGjoue4FDdHUkloRGElLZvNElu z8IheaBNCM7HJ2x7yR4XGk/sb3o0itgnbDHjkav88LPUnSKcg7stMcKXJGpPoBp/mqo0 wrmw== X-Gm-Message-State: AFq9FYLLqpnKI0jRLSNfUFK1VU0hyULBfys20XVKDdfHwU6pl+JvBDcp +kPllD+NUSCL6wwp9OmgRQLKKkIUOiS9y0DVIEQ9/80EnNpdCmD9kiMfHNVrsvVUymSrGfmlbvU /RbC7WGtaBtMzjERfDk0Jg/YIouzL6vUW1R6VUbek2fhgpafwjAWYw4xrmkko3TJa8SX8wZxMMy 530ftU327zJwJNbgER/am12LtzaSrGAuVH5SJEZ77GP09D60U= X-Gm-Gg: AYBFou3Z5Xxsgst2sbNDwXTIFeoIDQMLxyxYY3OgPUg5O4o7ixzrNRjtfqGuX/GzoGX v9+WHhm1mT5INGTnYOtaqzRujRPt4j5IFsK1xgVEbiQBj20z3JZDJr4xeua/o3u0HbJM3cqfwt/ HMgOxd2/CDtOiNmoxFmsAR8smVY4FIMKXaycHBk2ESmC/WvgEpTWPkieKEv7SLIfR4QF2E/1QO0 wyXZO82E1skVWZGbG/8Lc1w3mxpAerzIV4WMz/RntW/xQWdMtBtKuc43myzU+azSF/qFIZrpjlu /GTqXTnvbE5GwnlTS5uJd23sz2JaUjJXxokoesmgHy73S9c84u35zhT5l7kgda1hPbe3nRSaJ6T zugoVR0RBiare6hfs0gQC7cR4npSnTMxai1JjvKLtsPPHqCA= X-Received: by 2002:a05:600c:621a:b0:49f:c5aa:9ef4 with SMTP id 5b1f17b1804b1-4a996b9812emr32075055e9.8.1793187661685; Wed, 28 Oct 2026 04:41:01 -0700 (PDT) X-Received: by 2002:a05:600c:621a:b0:49f:c5aa:9ef4 with SMTP id 5b1f17b1804b1-4a996b9812emr32074375e9.8.1793187661081; Wed, 28 Oct 2026 04:41:01 -0700 (PDT) Received: from localhost ([2a00:23c6:e11d:fb01:6748:4fce:3e30:6e23]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a94f05e4e4sm27470415e9.3.2026.10.28.04.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 04:41:00 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess , Tom Tromey Subject: [PATCHv2 0/2] Address issues with auto-load safe path checking Date: Wed, 28 Oct 2026 11:40:55 +0000 Message-Id: X-Mailer: git-send-email 2.25.4 In-Reply-To: <878q3oqmzp.fsf@tromey.com> References: <878q3oqmzp.fsf@tromey.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: mQqtrjzJCHoD17zNpXIksGregZ8tDLa1JlHshZZpS90_1793187662 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom, You were right to ask for tests. As is too often the case, as I wrote the tests I ran into another bug in the same area, so now there are two patches. The first patch is new and addresses an existing bug which would cause legitimate files to be rejected in some edge cases. The second patch is the same code as you saw before (with a tweak to the comment in observable.h), with the test from patch #1 extended to cover this case too. Thanks, Andrew --- Andrew Burgess (2): gdb: check auto-load safe path after refreshing cached vector gdb: add debug_file_directory changed observer gdb/auto-load.c | 20 ++- gdb/observable.c | 1 + gdb/observable.h | 4 + gdb/symfile.c | 12 +- .../auto-load-after-debug-dir-change-1.gdb | 17 +++ .../auto-load-after-debug-dir-change-2.gdb | 17 +++ .../auto-load-after-debug-dir-change.exp | 124 ++++++++++++++++++ 7 files changed, 190 insertions(+), 5 deletions(-) create mode 100644 gdb/testsuite/gdb.base/auto-load-after-debug-dir-change-1.gdb create mode 100644 gdb/testsuite/gdb.base/auto-load-after-debug-dir-change-2.gdb create mode 100644 gdb/testsuite/gdb.base/auto-load-after-debug-dir-change.exp base-commit: b2fe3a449cb5d130ea2fec65bb214601826cdeff -- 2.25.4