From: Simon Marchi <simon.marchi@polymtl.ca>
To: John Reiser <jreiser@bitwagon.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] fix race when building ada-lex.c
Date: Sun, 29 Apr 2018 15:58:00 -0000 [thread overview]
Message-ID: <cded8f575a4c591382abd553e5fcc39e@polymtl.ca> (raw)
In-Reply-To: <6612c052-f77e-8650-bdbc-d985f1f10f85@bitwagon.com>
On 2018-04-28 17:13, John Reiser wrote:
> PR build/22873
> Prevent a race when building ada-lex.c, and any target of rules .c:.l
> or .c:.y.
> The target should be written only at the last step, else SIGINT (^C)
> can leave an inconsistent state. Being .PRECIOUS makes it even worse.
>
> gdb/ChangeLog:
> * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the
> last step, and do it atomically.
>
> [patch attached]
Hi John,
Thanks for the patch, it makes sense. I pushed it.
Simon
next prev parent reply other threads:[~2018-04-29 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-28 21:13 John Reiser
2018-04-29 15:58 ` Simon Marchi [this message]
2018-05-03 14:40 ` Build failure with flex 2.5.4 (Re: [PATCH] fix race when building ada-lex.c) Ulrich Weigand
2018-05-03 14:48 ` Simon Marchi
2018-05-03 15:08 ` Ulrich Weigand
2018-05-03 21:35 ` Simon Marchi
2018-05-04 9:07 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cded8f575a4c591382abd553e5fcc39e@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=jreiser@bitwagon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox