Re: Build failure with flex 2.5.4 (Re: [PATCH] fix race when building ada-lex.c)

[Simon Marchi <simon.marchi@ericsson.com>]

On 2018-05-03 11:08 AM, Ulrich Weigand wrote:
> Simon Marchi wrote:
> 
>> Huh, I also wondered whether --stdout was a widely available option.  I 
>> found it was added by this commit in flex:
>>
>>    https://github.com/westes/flex/commit/16fe6f3
>>
>> and since it is 16-17 years old, I didn't raise a flag.  But we can 
>> certainly use -t.  Can you confirm it works as intended on that system?
> 
> Yes, -t works as intended.

Thanks, I pushed this change.


From 4ea17de8f1985273215b515d48fbd59b2ced3cd1 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Thu, 3 May 2018 17:29:14 -0400
Subject: [PATCH] Use flex's -t option instead of --stdout

As reported in

  https://sourceware.org/ml/gdb-patches/2018-05/msg00042.html

some old versions of flex (2.5.4) don't support the --stdout switch.
Use -t, which is an alias.

gdb/ChangeLog:

	* Makefile.in (%.c: %.l): Use -t instead of --stdout.
---
 gdb/ChangeLog   | 4 ++++
 gdb/Makefile.in | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 1825c2c..1a44240 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2018-05-03  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* Makefile.in (%.c: %.l): Use -t instead of --stdout.
+
 2018-05-03  Pedro Alves  <palves@redhat.com>

 	* s390-linux-nat.c
diff --git a/gdb/Makefile.in b/gdb/Makefile.in
index be76928..87d74a7 100644
--- a/gdb/Makefile.in
+++ b/gdb/Makefile.in
@@ -2500,7 +2500,7 @@ po/$(PACKAGE).pot: force
 	  mv $@.new $@
 %.c: %.l
 	if [ "$(FLEX)" ] && $(FLEX) --version >/dev/null 2>&1; then \
-	    $(FLEX) --stdout $<  \
+	    $(FLEX) -t $<  \
 	    | sed -e '/extern.*malloc/d' \
 	        -e '/extern.*realloc/d' \
 	        -e '/extern.*free/d' \
-- 
2.7.4