From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42042 invoked by alias); 29 Apr 2018 15:58:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 42029 invoked by uid 89); 29 Apr 2018 15:58:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:112, Hx-languages-length:540, pushed X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 29 Apr 2018 15:58:30 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w3TFwNjB027749 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 29 Apr 2018 11:58:28 -0400 Received: by simark.ca (Postfix, from userid 112) id A21F31EF60; Sun, 29 Apr 2018 11:58:23 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 9CDE21E4C4; Sun, 29 Apr 2018 11:58:21 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 29 Apr 2018 15:58:00 -0000 From: Simon Marchi To: John Reiser Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] fix race when building ada-lex.c In-Reply-To: <6612c052-f77e-8650-bdbc-d985f1f10f85@bitwagon.com> References: <6612c052-f77e-8650-bdbc-d985f1f10f85@bitwagon.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 29 Apr 2018 15:58:23 +0000 X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00601.txt.bz2 On 2018-04-28 17:13, John Reiser wrote: > PR build/22873 > Prevent a race when building ada-lex.c, and any target of rules .c:.l > or .c:.y. > The target should be written only at the last step, else SIGINT (^C) > can leave an inconsistent state. Being .PRECIOUS makes it even worse. > > gdb/ChangeLog: > * gdb/Makefile.in: (.c:.l, .c:.y): Write the target only in the > last step, and do it atomically. > > [patch attached] Hi John, Thanks for the patch, it makes sense. I pushed it. Simon