From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Update create-version.sh to use common/version.h
Date: Sat, 26 Jan 2019 01:00:00 -0000 [thread overview]
Message-ID: <cbe1620df062edd2aa66f81e6ba25d2d@polymtl.ca> (raw)
In-Reply-To: <20190123172954.24421-2-tom@tromey.com>
On 2019-01-23 12:29, Tom Tromey wrote:
> This changes create-version.sh to have the generated file use
> common/version.h as the file name.
>
> 2019-01-23 Tom Tromey <tom@tromey.com>
>
> * common/create-version.sh: Use common/version.h.
> ---
> gdb/ChangeLog | 4 ++++
> gdb/common/create-version.sh | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/common/create-version.sh
> b/gdb/common/create-version.sh
> index 51cffe8db5..6e67a61357 100755
> --- a/gdb/common/create-version.sh
> +++ b/gdb/common/create-version.sh
> @@ -30,7 +30,7 @@ output="$4"
> rm -f version.c-tmp $output version.tmp
> date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$/\1/p'
> $srcdir/../bfd/version.h`
> sed -e "s/DATE/$date/" < $srcdir/version.in > version.tmp
> -echo '#include "version.h"' >> version.c-tmp
> +echo '#include "common/version.h"' >> version.c-tmp
> echo 'const char version[] = "'"`sed q version.tmp`"'";' >>
> version.c-tmp
> echo 'const char host_name[] = "'"$host_alias"'";' >> version.c-tmp
> echo 'const char target_name[] = "'"$target_alias"'";' >>
> version.c-tmp
Hi Tom,
Somebody reported this compilation error when building the simulator
with an aarch64 target (sorry about the formatting, I'm on web client):
ccache /opt/gcc/8.2/bin/gcc -DHAVE_CONFIG_H
-DWITH_DEFAULT_ALIGNMENT=NONSTRICT_ALIGNMENT -DDEFAULT_INLINE=0
-Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign
-Wno-unused -Wunused-value -Wunused-function -Wno-switch
-Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement
-Wempty-body -Wmissing-parameter-type -Wold-style-declaration
-Wold-style-definition -Wformat-nonliteral -I.
-I../../../binutils-gdb/sim/aarch64 -I../common
-I../../../binutils-gdb/sim/aarch64/../common -I../../include
-I../../../binutils-gdb/sim/aarch64/../../include -I../../bfd
-I../../../binutils-gdb/sim/aarch64/../../bfd -I../../opcodes
-I../../../binutils-gdb/sim/aarch64/../../opcodes -g3 -O0
-fsanitize=address -c -o version.o -MT version.o -MMD -MP -MF
.deps/version.Tpo version.c
version.c:1:10: fatal error: common/version.h: No such file or directory
#include "common/version.h"
^~~~~~~~~~~~~~~~~~
You can probably reproduce it with --enable-sim
--target=aarch64-linux-gnu.
Simon
next prev parent reply other threads:[~2019-01-26 1:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 17:30 [PATCH 0/3] Normalize common includes Tom Tromey
2019-01-23 17:30 ` [PATCH 3/3] Don't use -I for common subdirectory Tom Tromey
2019-01-23 17:30 ` [PATCH 2/3] Normalize includes to use common/ Tom Tromey
2019-01-25 4:17 ` [PATCH 0/3] Normalize common includes Joel Brobecker
2019-01-25 14:28 ` Tom Tromey
2019-01-25 16:47 ` John Baldwin
2019-01-25 21:32 ` Tom Tromey
[not found] ` <20190123172954.24421-2-tom@tromey.com>
2019-01-26 1:00 ` Simon Marchi [this message]
[not found] ` <6adb597a88e229b7996d156ea8208438@polymtl.ca>
2019-01-26 3:58 ` [PATCH 1/3] Update create-version.sh to use common/version.h Tom Tromey
2019-01-26 4:04 ` Tom Tromey
2019-01-26 4:41 ` Simon Marchi
2019-01-26 5:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbe1620df062edd2aa66f81e6ba25d2d@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox