From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Normalize common includes
Date: Fri, 25 Jan 2019 14:28:00 -0000 [thread overview]
Message-ID: <87fttgolqi.fsf@tromey.com> (raw)
In-Reply-To: <20190125041744.GC7566@adacore.com> (Joel Brobecker's message of "Fri, 25 Jan 2019 08:17:44 +0400")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> I think it's a good idea indeed. It's immediately clearer to me when
Joel> I see #include "common/something.h". The downside is having to update
Joel> all the includes when we move one file, but I think this one-off
Joel> is worth the extra clarity.
You could move the file and then re-run the script.
It even writes the ChangeLog for you :-)
Tom
next prev parent reply other threads:[~2019-01-25 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 17:30 Tom Tromey
2019-01-23 17:30 ` [PATCH 2/3] Normalize includes to use common/ Tom Tromey
2019-01-23 17:30 ` [PATCH 3/3] Don't use -I for common subdirectory Tom Tromey
2019-01-25 4:17 ` [PATCH 0/3] Normalize common includes Joel Brobecker
2019-01-25 14:28 ` Tom Tromey [this message]
2019-01-25 16:47 ` John Baldwin
2019-01-25 21:32 ` Tom Tromey
[not found] ` <20190123172954.24421-2-tom@tromey.com>
2019-01-26 1:00 ` [PATCH 1/3] Update create-version.sh to use common/version.h Simon Marchi
[not found] ` <6adb597a88e229b7996d156ea8208438@polymtl.ca>
2019-01-26 3:58 ` Tom Tromey
2019-01-26 4:04 ` Tom Tromey
2019-01-26 4:41 ` Simon Marchi
2019-01-26 5:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fttgolqi.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox