From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108863 invoked by alias); 25 Jan 2019 14:28:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108832 invoked by uid 89); 25 Jan 2019 14:28:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HX-HELO:sk:gateway, Hx-spam-relays-external:cmsmtp, H*r:cmsmtp, HX-Local-Domain:yes X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.97) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Jan 2019 14:28:09 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway31.websitewelcome.com (Postfix) with ESMTP id C16CA384D3C for ; Fri, 25 Jan 2019 08:28:06 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id n2SkgD4DHdnCen2SkgFmCy; Fri, 25 Jan 2019 08:28:06 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HUSKkNnf+LjV31VirtYaiFQQjdaLOTfYIOilzez60Zc=; b=GB3s8evHbqyNSNmCGGXRIBgDHw 1JX9bbtiOWpd6lobfwQJ7pMdG22gZwLstm8qIaAzicvyiPZip9uotJ75Kd6yQOj+XKMVA3sZLu3PU VYthcvAL5OC6JDM/jrzm5r12x; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:56634 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gn2Sk-003hUa-Dm; Fri, 25 Jan 2019 08:28:06 -0600 From: Tom Tromey To: Joel Brobecker Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Normalize common includes References: <20190123172954.24421-1-tom@tromey.com> <20190125041744.GC7566@adacore.com> Date: Fri, 25 Jan 2019 14:28:00 -0000 In-Reply-To: <20190125041744.GC7566@adacore.com> (Joel Brobecker's message of "Fri, 25 Jan 2019 08:17:44 +0400") Message-ID: <87fttgolqi.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00547.txt.bz2 >>>>> "Joel" == Joel Brobecker writes: Joel> I think it's a good idea indeed. It's immediately clearer to me when Joel> I see #include "common/something.h". The downside is having to update Joel> all the includes when we move one file, but I think this one-off Joel> is worth the extra clarity. You could move the file and then re-run the script. It even writes the ChangeLog for you :-) Tom