From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57993 invoked by alias); 26 Jan 2019 01:00:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57695 invoked by uid 89); 26 Jan 2019 01:00:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=unavailable version=3.3.2 spammy=H*F:D*ca, sim, H*r:112, simon X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 26 Jan 2019 01:00:20 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x0Q104qJ014371 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 25 Jan 2019 20:00:08 -0500 Received: by simark.ca (Postfix, from userid 112) id 159721E7B9; Fri, 25 Jan 2019 20:00:04 -0500 (EST) Received: from www.simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 111321E077; Fri, 25 Jan 2019 20:00:03 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 26 Jan 2019 01:00:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Update create-version.sh to use common/version.h In-Reply-To: <20190123172954.24421-2-tom@tromey.com> References: <20190123172954.24421-1-tom@tromey.com> <20190123172954.24421-2-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00554.txt.bz2 On 2019-01-23 12:29, Tom Tromey wrote: > This changes create-version.sh to have the generated file use > common/version.h as the file name. > > 2019-01-23 Tom Tromey > > * common/create-version.sh: Use common/version.h. > --- > gdb/ChangeLog | 4 ++++ > gdb/common/create-version.sh | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/common/create-version.sh > b/gdb/common/create-version.sh > index 51cffe8db5..6e67a61357 100755 > --- a/gdb/common/create-version.sh > +++ b/gdb/common/create-version.sh > @@ -30,7 +30,7 @@ output="$4" > rm -f version.c-tmp $output version.tmp > date=`sed -n -e 's/^.* BFD_VERSION_DATE \(.*\)$/\1/p' > $srcdir/../bfd/version.h` > sed -e "s/DATE/$date/" < $srcdir/version.in > version.tmp > -echo '#include "version.h"' >> version.c-tmp > +echo '#include "common/version.h"' >> version.c-tmp > echo 'const char version[] = "'"`sed q version.tmp`"'";' >> > version.c-tmp > echo 'const char host_name[] = "'"$host_alias"'";' >> version.c-tmp > echo 'const char target_name[] = "'"$target_alias"'";' >> > version.c-tmp Hi Tom, Somebody reported this compilation error when building the simulator with an aarch64 target (sorry about the formatting, I'm on web client): ccache /opt/gcc/8.2/bin/gcc -DHAVE_CONFIG_H -DWITH_DEFAULT_ALIGNMENT=NONSTRICT_ALIGNMENT -DDEFAULT_INLINE=0 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wpointer-sign -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wmissing-prototypes -Wdeclaration-after-statement -Wempty-body -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -I. -I../../../binutils-gdb/sim/aarch64 -I../common -I../../../binutils-gdb/sim/aarch64/../common -I../../include -I../../../binutils-gdb/sim/aarch64/../../include -I../../bfd -I../../../binutils-gdb/sim/aarch64/../../bfd -I../../opcodes -I../../../binutils-gdb/sim/aarch64/../../opcodes -g3 -O0 -fsanitize=address -c -o version.o -MT version.o -MMD -MP -MF .deps/version.Tpo version.c version.c:1:10: fatal error: common/version.h: No such file or directory #include "common/version.h" ^~~~~~~~~~~~~~~~~~ You can probably reproduce it with --enable-sim --target=aarch64-linux-gnu. Simon