From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 5/5] Eliminate make_cleanup_ui_file_delete / make ui_file a class hierarchy
Date: Wed, 01 Feb 2017 00:31:00 -0000 [thread overview]
Message-ID: <c9982890-0e9c-a28a-6aff-e8f251a0c695@redhat.com> (raw)
In-Reply-To: <f7dcd328-3eb4-5e79-93cb-b36f527d3159@redhat.com>
On 01/25/2017 07:47 PM, Pedro Alves wrote:
> On 01/25/2017 07:31 PM, Pedro Alves wrote:
>
>> Here's the diff to the incoming v3. I think this addresses all
>> your comments. The only other change is that I realized that
>> ui_file should be abstract, so that people don't try to allocate
>> one to build a "/dev/null" stream. I've checked the AIX build
>> on gcc119. I'll send v3 shortly.
>
> Here it is. I've pushed it to users/palves/ui_file_v3 too,
> along with the (not posted) "move tee down" follow up patch
> I mentioned.
Today I rebased this on master, and that had conflicts with the
gdb_disassembler wrapper series. Getting rid of the ui_file_rewind
calls in disasm.c required redoing a part of the gdb_disassembler
changes to disasm.c. I think the result looks even better in the end.
I've pushed in the small precursor patches to master, and posted
a v4. Let me know what you think of it.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2017-02-01 0:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 1:39 [PATCH 0/5] Eliminate cleanups & make ui_file a C++ " Pedro Alves
2017-01-17 1:39 ` [PATCH 3/5] gdb/stack.c: Remove unused mem_fileopen Pedro Alves
2017-01-17 1:39 ` [PATCH 1/5] gdb: make_scoped_restore and types convertible to T Pedro Alves
2017-01-17 1:39 ` [PATCH 5/5] Eliminate make_cleanup_ui_file_delete / make ui_file a class hierarchy Pedro Alves
2017-01-17 19:57 ` Simon Marchi
2017-01-17 19:58 ` Simon Marchi
2017-01-23 16:58 ` Pedro Alves
2017-01-23 17:17 ` Pedro Alves
2017-01-23 19:18 ` Simon Marchi
2017-01-23 23:19 ` [PATCH v2 " Pedro Alves
2017-01-24 18:29 ` Simon Marchi
2017-01-24 19:14 ` Simon Marchi
2017-01-25 18:37 ` Pedro Alves
2017-01-25 17:52 ` Pedro Alves
2017-01-25 19:31 ` Pedro Alves
2017-01-25 19:47 ` [PATCH v3 " Pedro Alves
2017-02-01 0:31 ` Pedro Alves [this message]
2017-01-25 18:27 ` [PATCH v2 " Pedro Alves
2017-01-24 19:11 ` Simon Marchi
2017-01-25 18:28 ` Pedro Alves
2017-01-25 18:39 ` Simon Marchi
2017-01-25 18:41 ` Pedro Alves
2017-01-17 1:39 ` [PATCH 2/5] gdb/varobj.c: Fix leak Pedro Alves
2017-01-17 1:47 ` [PATCH 4/5] gdb/mi/mi-interp.c: Fix typos Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9982890-0e9c-a28a-6aff-e8f251a0c695@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox