From: Pedro Alves <palves@redhat.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/5] gdb/varobj.c: Fix leak
Date: Tue, 17 Jan 2017 01:39:00 -0000 [thread overview]
Message-ID: <1484617147-2506-3-git-send-email-palves@redhat.com> (raw)
In-Reply-To: <1484617147-2506-1-git-send-email-palves@redhat.com>
Whoops, this function returns a std::string.
gdb/ChangeLog:
2017-01-17 Pedro Alves <palves@redhat.com>
* varobj.c (varobj_value_get_print_value): Remove xstrdup call.
---
gdb/varobj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/varobj.c b/gdb/varobj.c
index 30dfb86..bcca6c6 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -2432,7 +2432,7 @@ varobj_value_get_print_value (struct value *value,
if (dynamic_varobj_has_child_method (var))
{
do_cleanups (old_chain);
- return xstrdup ("{...}");
+ return "{...}";
}
if (PyObject_HasAttr (value_formatter, gdbpy_to_string_cst))
--
2.5.5
next prev parent reply other threads:[~2017-01-17 1:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 1:39 [PATCH 0/5] Eliminate cleanups & make ui_file a C++ class hierarchy Pedro Alves
2017-01-17 1:39 ` [PATCH 3/5] gdb/stack.c: Remove unused mem_fileopen Pedro Alves
2017-01-17 1:39 ` Pedro Alves [this message]
2017-01-17 1:39 ` [PATCH 5/5] Eliminate make_cleanup_ui_file_delete / make ui_file a class hierarchy Pedro Alves
2017-01-17 19:57 ` Simon Marchi
2017-01-17 19:58 ` Simon Marchi
2017-01-23 16:58 ` Pedro Alves
2017-01-23 17:17 ` Pedro Alves
2017-01-23 19:18 ` Simon Marchi
2017-01-23 23:19 ` [PATCH v2 " Pedro Alves
2017-01-24 18:29 ` Simon Marchi
2017-01-24 19:14 ` Simon Marchi
2017-01-25 18:37 ` Pedro Alves
2017-01-25 17:52 ` Pedro Alves
2017-01-25 19:31 ` Pedro Alves
2017-01-25 19:47 ` [PATCH v3 " Pedro Alves
2017-02-01 0:31 ` Pedro Alves
2017-01-25 18:27 ` [PATCH v2 " Pedro Alves
2017-01-24 19:11 ` Simon Marchi
2017-01-25 18:28 ` Pedro Alves
2017-01-25 18:39 ` Simon Marchi
2017-01-25 18:41 ` Pedro Alves
2017-01-17 1:39 ` [PATCH 1/5] gdb: make_scoped_restore and types convertible to T Pedro Alves
2017-01-17 1:47 ` [PATCH 4/5] gdb/mi/mi-interp.c: Fix typos Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484617147-2506-3-git-send-email-palves@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox