From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111211 invoked by alias); 1 Feb 2017 00:31:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111064 invoked by uid 89); 1 Feb 2017 00:31:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=conflicts, Hx-languages-length:1014 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 01 Feb 2017 00:31:41 +0000 Received: from smtp.corp.redhat.com (int-mx16.intmail.prod.int.phx2.redhat.com [10.5.11.28]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C868D3B722; Wed, 1 Feb 2017 00:31:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 30266899C7; Wed, 1 Feb 2017 00:31:41 +0000 (UTC) Subject: Re: [PATCH v3 5/5] Eliminate make_cleanup_ui_file_delete / make ui_file a class hierarchy To: Simon Marchi References: <1484617147-2506-1-git-send-email-palves@redhat.com> <1484617147-2506-6-git-send-email-palves@redhat.com> <5533317a1fdb2e5f36e64731aef84993@polymtl.ca> <4a6cce94-1533-36e9-6015-330e2e014a98@redhat.com> <558e1e55-23eb-716e-8117-c18d7bded7b8@redhat.com> <79c06dbccef0c33309d208316be207f4@polymtl.ca> <8bf8c6d9-9bbb-be9b-ee5e-99c2c3fa5b8e@redhat.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 01 Feb 2017 00:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00004.txt.bz2 On 01/25/2017 07:47 PM, Pedro Alves wrote: > On 01/25/2017 07:31 PM, Pedro Alves wrote: > >> Here's the diff to the incoming v3. I think this addresses all >> your comments. The only other change is that I realized that >> ui_file should be abstract, so that people don't try to allocate >> one to build a "/dev/null" stream. I've checked the AIX build >> on gcc119. I'll send v3 shortly. > > Here it is. I've pushed it to users/palves/ui_file_v3 too, > along with the (not posted) "move tee down" follow up patch > I mentioned. Today I rebased this on master, and that had conflicts with the gdb_disassembler wrapper series. Getting rid of the ui_file_rewind calls in disasm.c required redoing a part of the gdb_disassembler changes to disasm.c. I think the result looks even better in the end. I've pushed in the small precursor patches to master, and posted a v4. Let me know what you think of it. Thanks, Pedro Alves