From: Simon Marchi <simark@simark.ca>
To: Lukas Durfina <ldurfina@tachyum.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Simplification in charset.c
Date: Thu, 20 Feb 2020 14:54:00 -0000 [thread overview]
Message-ID: <c99144cd-dfe1-f866-6691-3e48ccf61820@simark.ca> (raw)
In-Reply-To: <20200220121024.116818-1-ldurfina@tachyum.com>
On 2020-02-20 7:10 a.m., Lukas Durfina wrote:
> @@ -818,13 +818,10 @@ find_charset_names (void)
> {
> std::string iconv_dir = relocate_gdb_directory (ICONV_BIN,
> ICONV_BIN_RELOCATABLE);
> - iconv_program
> - = concat (iconv_dir.c_str(), SLASH_STRING, "iconv", (char *) NULL);
> + iconv_program = iconv_dir + SLASH_STRING + "iconv";
> }
> -#else
> - iconv_program = xstrdup ("iconv");
> #endif
> - args[0] = iconv_program;
> + args[0] = iconv_program.c_str();
Missing space before parenthesis.
The patch LGTM with that fixed. Do you have push access, or would you like me to
push the patch on your behalf?
Simon
next prev parent reply other threads:[~2020-02-20 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 12:10 Lukas Durfina
2020-02-20 14:54 ` Simon Marchi [this message]
2020-02-20 15:01 ` Lukas Durfina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c99144cd-dfe1-f866-6691-3e48ccf61820@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=ldurfina@tachyum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox