From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-164519-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 66227 invoked by alias); 20 Feb 2020 14:54:14 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 66119 invoked by uid 89); 20 Feb 2020 14:54:13 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:661
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2020 14:54:12 +0000
Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218])	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 0241A1E5FA;	Thu, 20 Feb 2020 09:54:09 -0500 (EST)
Subject: Re: [PATCH] gdb: Simplification in charset.c
To: Lukas Durfina <ldurfina@tachyum.com>, gdb-patches@sourceware.org
References: <20200220121024.116818-1-ldurfina@tachyum.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <c99144cd-dfe1-f866-6691-3e48ccf61820@simark.ca>
Date: Thu, 20 Feb 2020 14:54:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200220121024.116818-1-ldurfina@tachyum.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2020-02/txt/msg00821.txt.bz2

On 2020-02-20 7:10 a.m., Lukas Durfina wrote:
> @@ -818,13 +818,10 @@ find_charset_names (void)
>    {
>      std::string iconv_dir = relocate_gdb_directory (ICONV_BIN,
>  						    ICONV_BIN_RELOCATABLE);
> -    iconv_program
> -      = concat (iconv_dir.c_str(), SLASH_STRING, "iconv", (char *) NULL);
> +    iconv_program = iconv_dir + SLASH_STRING + "iconv";
>    }
> -#else
> -  iconv_program = xstrdup ("iconv");
>  #endif
> -  args[0] = iconv_program;
> +  args[0] = iconv_program.c_str();

Missing space before parenthesis.

The patch LGTM with that fixed.  Do you have push access, or would you like me to
push the patch on your behalf?

Simon