RE: [PATCH] gdb: Simplification in charset.c

[Lukas Durfina <ldurfina@tachyum.com>]

> -----Original Message-----
> From: Simon Marchi <simark@simark.ca>
> Sent: Thursday, February 20, 2020 3:54 PM
> To: Lukas Durfina <ldurfina@tachyum.com>; gdb-patches@sourceware.org
> Subject: Re: [PATCH] gdb: Simplification in charset.c
> 
> On 2020-02-20 7:10 a.m., Lukas Durfina wrote:
> > @@ -818,13 +818,10 @@ find_charset_names (void)
> >    {
> >      std::string iconv_dir = relocate_gdb_directory (ICONV_BIN,
> >
> ICONV_BIN_RELOCATABLE);
> > -    iconv_program
> > -      = concat (iconv_dir.c_str(), SLASH_STRING, "iconv", (char *) NULL);
> > +    iconv_program = iconv_dir + SLASH_STRING + "iconv";
> >    }
> > -#else
> > -  iconv_program = xstrdup ("iconv");
> >  #endif
> > -  args[0] = iconv_program;
> > +  args[0] = iconv_program.c_str();
> 
> Missing space before parenthesis.
> 
> The patch LGTM with that fixed.  Do you have push access, or would you like
> me to push the patch on your behalf?
> 
> Simon

Ahh, sorry for that missing space.
I do not have push access yet. Push it please.

Thank you

Lukas