From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75051 invoked by alias); 20 Feb 2020 15:01:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 74835 invoked by uid 89); 20 Feb 2020 15:00:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:0800 X-HELO: mail.tachyum.com Received: from Unknown (HELO mail.tachyum.com) (66.160.133.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2020 15:00:49 +0000 Received: by mail.tachyum.com (Postfix, from userid 1001) id 1DED48D7; Wed, 19 Feb 2020 23:00:40 -0800 (PST) Received: from THQ-EX2016.tachyum.com (unknown [10.7.1.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.tachyum.com (Postfix) with ESMTPS id 4A8328D4; Wed, 19 Feb 2020 23:00:39 -0800 (PST) Received: from THQ-EX2016.tachyum.com (10.7.1.16) by THQ-EX2016.tachyum.com (10.7.1.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Thu, 20 Feb 2020 07:00:42 -0800 Received: from THQ-EX2016.tachyum.com ([10.7.1.16]) by THQ-EX2016.tachyum.com ([10.7.1.16]) with mapi id 15.01.1913.005; Thu, 20 Feb 2020 07:00:39 -0800 From: Lukas Durfina To: Simon Marchi , "gdb-patches@sourceware.org" Subject: RE: [PATCH] gdb: Simplification in charset.c Date: Thu, 20 Feb 2020 15:01:00 -0000 Message-ID: <15534cb1e5a44094b3898c8798df8194@tachyum.com> References: <20200220121024.116818-1-ldurfina@tachyum.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-SW-Source: 2020-02/txt/msg00822.txt.bz2 DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU2lt b24gTWFyY2hpIDxzaW1hcmtAc2ltYXJrLmNhPg0KPiBTZW50OiBUaHVyc2Rh eSwgRmVicnVhcnkgMjAsIDIwMjAgMzo1NCBQTQ0KPiBUbzogTHVrYXMgRHVy ZmluYSA8bGR1cmZpbmFAdGFjaHl1bS5jb20+OyBnZGItcGF0Y2hlc0Bzb3Vy Y2V3YXJlLm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBnZGI6IFNpbXBs aWZpY2F0aW9uIGluIGNoYXJzZXQuYw0KPiANCj4gT24gMjAyMC0wMi0yMCA3 OjEwIGEubS4sIEx1a2FzIER1cmZpbmEgd3JvdGU6DQo+ID4gQEAgLTgxOCwx MyArODE4LDEwIEBAIGZpbmRfY2hhcnNldF9uYW1lcyAodm9pZCkNCj4gPiAg ICB7DQo+ID4gICAgICBzdGQ6OnN0cmluZyBpY29udl9kaXIgPSByZWxvY2F0 ZV9nZGJfZGlyZWN0b3J5IChJQ09OVl9CSU4sDQo+ID4NCj4gSUNPTlZfQklO X1JFTE9DQVRBQkxFKTsNCj4gPiAtICAgIGljb252X3Byb2dyYW0NCj4gPiAt ICAgICAgPSBjb25jYXQgKGljb252X2Rpci5jX3N0cigpLCBTTEFTSF9TVFJJ TkcsICJpY29udiIsIChjaGFyICopIE5VTEwpOw0KPiA+ICsgICAgaWNvbnZf cHJvZ3JhbSA9IGljb252X2RpciArIFNMQVNIX1NUUklORyArICJpY29udiI7 DQo+ID4gICAgfQ0KPiA+IC0jZWxzZQ0KPiA+IC0gIGljb252X3Byb2dyYW0g PSB4c3RyZHVwICgiaWNvbnYiKTsNCj4gPiAgI2VuZGlmDQo+ID4gLSAgYXJn c1swXSA9IGljb252X3Byb2dyYW07DQo+ID4gKyAgYXJnc1swXSA9IGljb252 X3Byb2dyYW0uY19zdHIoKTsNCj4gDQo+IE1pc3Npbmcgc3BhY2UgYmVmb3Jl IHBhcmVudGhlc2lzLg0KPiANCj4gVGhlIHBhdGNoIExHVE0gd2l0aCB0aGF0 IGZpeGVkLiAgRG8geW91IGhhdmUgcHVzaCBhY2Nlc3MsIG9yIHdvdWxkIHlv dSBsaWtlDQo+IG1lIHRvIHB1c2ggdGhlIHBhdGNoIG9uIHlvdXIgYmVoYWxm Pw0KPiANCj4gU2ltb24NCg0KQWhoLCBzb3JyeSBmb3IgdGhhdCBtaXNzaW5n IHNwYWNlLg0KSSBkbyBub3QgaGF2ZSBwdXNoIGFjY2VzcyB5ZXQuIFB1c2gg aXQgcGxlYXNlLg0KDQpUaGFuayB5b3UNCg0KTHVrYXMNCg== >From gdb-patches-return-164521-listarch-gdb-patches=sources.redhat.com@sourceware.org Thu Feb 20 15:44:24 2020 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 35664 invoked by alias); 20 Feb 2020 15:44:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 35626 invoked by uid 89); 20 Feb 2020 15:44:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:690 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Feb 2020 15:44:14 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 01DC21E598; Thu, 20 Feb 2020 10:44:12 -0500 (EST) Subject: Re: [PATCH 01/14] Fix latent bug in dwarf2_find_containing_comp_unit To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200215165444.32653-1-tom@tromey.com> <20200215165444.32653-2-tom@tromey.com> <01167589-fae4-39a0-1ebe-0c7d4cbf52b5@simark.ca> <87o8tu3c1g.fsf@tromey.com> <87o8tu86ci.fsf@tromey.com> From: Simon Marchi Message-ID: <3a3f1f39-c715-58ba-06a8-2980afb82c53@simark.ca> Date: Thu, 20 Feb 2020 15:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87o8tu86ci.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00823.txt.bz2 Content-length: 626 On 2020-02-19 7:12 p.m., Tom Tromey wrote: > Simon> By refactoring the code a bit, we could maybe factor out the > Simon> meat of this function into one that operates on an std::vector instead > Simon> of on a dwarf2_per_objfile. It should then be feasible to create an std::vector with > Simon> dwarf2_per_cu_data elements out of thin air to unit-test the function, including edge > Simon> cases like this. > > Oops, I meant to attach the patch in that last email. > > Let me know what you think. > > Tom Thanks, that LGTM. If you want to use std::binary_search, that would be fine as well. Simon