Re: [PATCH 2/2] [gdb/testsuite] Fix host_file_normalize_mingw

[Tom de Vries <tdevries@suse.de>]

On 9/2/25 13:34, Pedro Alves wrote:
> Hi Tom,
> 
> On 2025-09-02 10:18, Tom de Vries wrote:
> 
>> I ran the test-case on both x86_64-linux and msys2-ucrt64, and it passed in both cases, so I think it should be fine.
>>
>> Feel free to commit this together with the first patch, or perhaps to combined into one patch.
>>
>> Given that the second patch now changes the setup of the test-case, I think squashing makes more sense.
> 
> I tried a combined patch, but it makes it hard to see the changes to host_file_normalize_mingw, because we'd
> be moving the code to a separate procedure and changing it at the same time.
> 
> So I kept the patches separate, but adjusted the first patch to use the "proc test" way.  I think it makes
> sense this way, and lets me keep you as main author of that patch.
> 
Hi Pedro,

I see, agreed.

> I sent it all as a v2 here:
>     https://inbox.sourceware.org/gdb-patches/20250902112742.1407890-1-pedro@palves.net/T/
> 
> I didn't merge it yet, I wanted to give you a chance to double check the commit logs.
> The resulting code is the exact same, though.


LGTM, please apply.

Thanks,
- Tom