Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [gdb/testsuite] Fix host_file_normalize_mingw
Date: Tue, 2 Sep 2025 12:34:40 +0100	[thread overview]
Message-ID: <4384029d-6ddb-474f-aea9-17b1e146d439@palves.net> (raw)
In-Reply-To: <f49de1d1-c4c0-46f4-817d-3e69574141c2@suse.de>

Hi Tom,

On 2025-09-02 10:18, Tom de Vries wrote:

> I ran the test-case on both x86_64-linux and msys2-ucrt64, and it passed in both cases, so I think it should be fine.
> 
> Feel free to commit this together with the first patch, or perhaps to combined into one patch.
> 
> Given that the second patch now changes the setup of the test-case, I think squashing makes more sense.

I tried a combined patch, but it makes it hard to see the changes to host_file_normalize_mingw, because we'd
be moving the code to a separate procedure and changing it at the same time.

So I kept the patches separate, but adjusted the first patch to use the "proc test" way.  I think it makes
sense this way, and lets me keep you as main author of that patch.

I sent it all as a v2 here:
   https://inbox.sourceware.org/gdb-patches/20250902112742.1407890-1-pedro@palves.net/T/

I didn't merge it yet, I wanted to give you a chance to double check the commit logs.
The resulting code is the exact same, though.

Pedro Alves

  reply	other threads:[~2025-09-02 11:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 13:14 [PATCH 0/2] [gdb/testsuite] Fix host_file_normalize with host mingw Tom de Vries
2025-08-27 13:14 ` [PATCH 1/2] [gdb/testsuite] Add gdb.testsuite/mount-point-map.exp Tom de Vries
2025-08-27 13:14 ` [PATCH 2/2] [gdb/testsuite] Fix host_file_normalize_mingw Tom de Vries
2025-08-29 19:47   ` Pedro Alves
2025-09-02  9:18     ` Tom de Vries
2025-09-02 11:34       ` Pedro Alves [this message]
2025-09-02 11:44         ` Tom de Vries
2025-09-02 12:06           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4384029d-6ddb-474f-aea9-17b1e146d439@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox